Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: sdk/lib/io/http_parser.dart

Issue 2946283002: Fix a couple of doc comment references - and many spelling mistakes (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sdk/lib/core/uri.dart ('k') | sdk/lib/io/secure_server_socket.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart.io; 5 part of dart.io;
6 6
7 // Global constants. 7 // Global constants.
8 class _Const { 8 class _Const {
9 // Bytes for "HTTP". 9 // Bytes for "HTTP".
10 static const HTTP = const [72, 84, 84, 80]; 10 static const HTTP = const [72, 84, 84, 80];
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 // TODO(26379): add test for this branch. 205 // TODO(26379): add test for this branch.
206 return new Stream<List<int>>.fromIterable([bufferedData]).listen(onData, 206 return new Stream<List<int>>.fromIterable([bufferedData]).listen(onData,
207 onError: onError, onDone: onDone, cancelOnError: cancelOnError); 207 onError: onError, onDone: onDone, cancelOnError: cancelOnError);
208 } 208 }
209 } 209 }
210 } 210 }
211 211
212 /** 212 /**
213 * HTTP parser which parses the data stream given to [consume]. 213 * HTTP parser which parses the data stream given to [consume].
214 * 214 *
215 * If an HTTP parser error occours, the parser will signal an error to either 215 * If an HTTP parser error occurs, the parser will signal an error to either
216 * the current _HttpIncoming or the _parser itself. 216 * the current _HttpIncoming or the _parser itself.
217 * 217 *
218 * The connection upgrades (e.g. switching from HTTP/1.1 to the 218 * The connection upgrades (e.g. switching from HTTP/1.1 to the
219 * WebSocket protocol) is handled in a special way. If connection 219 * WebSocket protocol) is handled in a special way. If connection
220 * upgrade is specified in the headers, then on the callback to 220 * upgrade is specified in the headers, then on the callback to
221 * [:responseStart:] the [:upgrade:] property on the [:HttpParser:] 221 * [:responseStart:] the [:upgrade:] property on the [:HttpParser:]
222 * object will be [:true:] indicating that from now on the protocol is 222 * object will be [:true:] indicating that from now on the protocol is
223 * not HTTP anymore and no more callbacks will happen, that is 223 * not HTTP anymore and no more callbacks will happen, that is
224 * [:dataReceived:] and [:dataEnd:] are not called in this case as 224 * [:dataReceived:] and [:dataEnd:] are not called in this case as
225 * there is no more HTTP data. After the upgrade the method 225 * there is no more HTTP data. After the upgrade the method
(...skipping 821 matching lines...) Expand 10 before | Expand all | Expand 10 after
1047 } 1047 }
1048 } 1048 }
1049 1049
1050 void _reportError(error, [stackTrace]) { 1050 void _reportError(error, [stackTrace]) {
1051 if (_socketSubscription != null) _socketSubscription.cancel(); 1051 if (_socketSubscription != null) _socketSubscription.cancel();
1052 _state = _State.FAILURE; 1052 _state = _State.FAILURE;
1053 _controller.addError(error, stackTrace); 1053 _controller.addError(error, stackTrace);
1054 _controller.close(); 1054 _controller.close();
1055 } 1055 }
1056 } 1056 }
OLDNEW
« no previous file with comments | « sdk/lib/core/uri.dart ('k') | sdk/lib/io/secure_server_socket.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698