pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart - Issue 2946273002: Implement override-based type inference for instance methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart

Issue 2946273002: Implement override-based type inference for instance methods. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart

diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart

index cde2c48bfae47204ad694cbec904c1c40a0526c5..81158aa7ca3a42eddb278e6e624632ae533e74b7 100644

--- a/pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart

+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart

@@ -195,7 +195,6 @@ abstract class KernelClassBuilder

if (declaredMember.kind == ProcedureKind.Method &&

interfaceMember.kind == ProcedureKind.Method) {

checkMethodOverride(declaredMember, interfaceMember);

- return;

}

// TODO(ahe): Handle other cases: accessors, operators, and fields.