Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: ash/system/power/tablet_power_button_controller.cc

Issue 2946233003: cros: stop forcing off display when powerd reports SuspendDone (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/power/tablet_power_button_controller.cc
diff --git a/ash/system/power/tablet_power_button_controller.cc b/ash/system/power/tablet_power_button_controller.cc
index 4beeb3e4c26ae88b9ab83dba45320895564a63f0..58e9a8d4cd5535e5d0d86f6c22244aeedb8a4de9 100644
--- a/ash/system/power/tablet_power_button_controller.cc
+++ b/ash/system/power/tablet_power_button_controller.cc
@@ -159,6 +159,10 @@ void TabletPowerButtonController::BrightnessChanged(int level,
void TabletPowerButtonController::SuspendDone(
const base::TimeDelta& sleep_duration) {
last_resume_time_ = tick_clock_->NowTicks();
+ // Device should always stopped forcing off backlights when suspend is done.
+ // This will handle the case when tablet power button pressed causing system
+ // resuming, but power button event is not delivered.
Daniel Erat 2017/06/22 18:08:40 nit: maybe just something like: // Stop forcing b
Qiang(Joe) Xu 2017/06/22 18:36:35 Done.
+ SetDisplayForcedOff(false);
}
void TabletPowerButtonController::LidEventReceived(

Powered by Google App Engine
This is Rietveld 408576698