tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 99d8a56fdf662c12636be11e4ad880676a2d88b1..453e6215ee5ab788e8084a29063a33c18b2dbcb1 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -65614,6 +65614,21 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="Scheduling.PendingTreeRasterDuration"

[Ilya Sherman, 2017/06/22 16:34:42]

Did you mean to add this to a histogram_suffixes list as well?

[Khushal, 2017/06/22 16:53:04]

It will only be measured in the renderer, since the pending tree is created in
the renderer only.

[Ilya Sherman, 2017/06/22 17:00:10]

So, should this histogram name include "Renderer" in it?

[Khushal, 2017/06/22 17:31:38]

Sure. Then I'll just add it with the suffix for Scheduling.PendingTreeDuration
to stay consistent. But both of these would have data from the renderer only.

[Ilya Sherman, 2017/06/22 21:20:45]

I mean... the C++ code generates some specific histogram name, and I *think*
that name includes "Renderer" in it, IIUC.  Listing this among
histogram_suffixes even if only one of the suffixes is used seems ok to me.

+  units="microseconds">

[Ilya Sherman, 2017/06/22 16:34:42]

nit: Please run "git cl format" to fix up the formatting in this file.  In fact,
it should be automatically run as a presubmit hook, and give a warning if it
fails.  Did you see that warning when uploading this change?

[Khushal, 2017/06/22 16:53:04]

I didn't see a warning. In fact running it is touching an unrelated histogram in
this file.

[Ilya Sherman, 2017/06/22 17:00:10]

Hmm, that's odd :/  I wonder why the presubmit isn't triggering correctly...

[Khushal, 2017/06/22 17:31:38]

And its failing on some weird error as well:

Error: Unrecognized attributes "type" in tag "enum"

[Ilya Sherman, 2017/06/22 21:20:45]

That should go away if you sync your client.  I recently simplified the file
format by dropping the type="int" annotations from all of the entries, and it
looks like some CLs landed after mine without running the presubmit, and hence
broke things a bit.  I believe it's fixed at ToT.

[Khushal, 2017/06/22 21:55:33]

Oh. Thanks for the update.

+  <owner>khushalsagar@chromium.org</owner>
+  <summary>
+    Time between starting raster work on the pending tree and when it is ready
+    to activate. Unlike PendingTreeDuration which includes the time to commit

[Ilya Sherman, 2017/06/22 16:34:42]

nit: I'd add a dash here between "PendingTreeDuration" and "which" – it makes it
easier to see where the PendingTreeDuration description ends (if you also add
another dash below, between "activated" and "this").

[Khushal, 2017/06/22 16:53:04]

Done.

+    to this tree, the raster duration, and the time for which the pending
+    tree waits before it can be activated, this only measures the time taken to
+    rasterize tiles required for activation.
+    
+    The interval is recorded each time we are notifed that a pending tree is
+    ready for activation.
+  </summary>
+</histogram>
+
 <histogram name="Scheduling.PrepareTilesDuration" units="microseconds">
   <obsolete>
     Replaced by PrepareTIlesDuration2, due to inefficient bucketing scheme.