Issue 2946173002: VM: Allow trailing comma in assert statements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2946173002: VM: Allow trailing comma in assert statements. (Closed)

Created:
3 years, 6 months ago by rmacnak

Modified:
3 years, 6 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -8 lines)			Patch
M	runtime/vm/parser.cc	View	2 chunks	+19 lines, -7 lines	0 comments	Download
A	tests/language/assert_trailing_comma_test.dart	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language_kernel.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 6 months ago (2017-06-21 16:08:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
095ff155fd51c66473b663b43fc4eb503ccdf45c.