Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: runtime/bin/BUILD.gn

Issue 2946123002: [fuchsia] Make symbols in the Dart VM visible, so they are available to the profiler. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/BUILD.gn ('k') | runtime/third_party/double-conversion/src/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/BUILD.gn
diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn
index 1a4907c3a7d789919de4a0123d4128615d934018..5176077b9da818f3fdbcca1cf9285e30c1ed7fe4 100644
--- a/runtime/bin/BUILD.gn
+++ b/runtime/bin/BUILD.gn
@@ -237,6 +237,9 @@ static_library("libdart_builtin") {
"..:dart_config",
"..:dart_maybe_product_config",
]
+ if (is_fuchsia) {
+ configs -= [ "//build/config:symbol_visibility_hidden" ]
+ }
public_configs = [ ":libdart_builtin_config" ]
deps = [
":generate_blink_cc_file",
@@ -276,6 +279,9 @@ executable("gen_snapshot") {
"..:dart_precompiler_config",
"..:dart_use_target_arch_config",
]
+ if (is_fuchsia) {
+ configs -= [ "//build/config:symbol_visibility_hidden" ]
+ }
deps = [
":gen_resources_cc",
":gen_snapshot_dart_io",
@@ -344,6 +350,9 @@ source_set("gen_snapshot_dart_io") {
"..:dart_maybe_product_config",
"..:dart_precompiler_config",
]
+ if (is_fuchsia) {
+ configs -= [ "//build/config:symbol_visibility_hidden" ]
+ }
deps = [
"$dart_zlib_path",
@@ -390,6 +399,9 @@ template("dart_io") {
"..:dart_config",
"..:dart_maybe_product_config",
]
+ if (is_fuchsia) {
+ configs -= [ "//build/config:symbol_visibility_hidden" ]
+ }
custom_sources_filter = [
"*_test.cc",
"*_test.h",
@@ -605,7 +617,9 @@ template("dart_executable") {
"..:dart_config",
"..:dart_maybe_product_config",
] + extra_configs
-
+ if (is_fuchsia) {
+ configs -= [ "//build/config:symbol_visibility_hidden" ]
+ }
if (defined(is_fuchsia_host) && is_fuchsia_host) {
# We already have these in the standalone build, but Fuchsia doesn't
# have them. They are needed for running Fuchsia binaries built for the
@@ -854,6 +868,9 @@ executable("run_vm_tests") {
"..:dart_maybe_product_config",
"..:dart_use_target_arch_config",
]
+ if (is_fuchsia) {
+ configs -= [ "//build/config:symbol_visibility_hidden" ]
+ }
deps = [
":dart_snapshot_cc",
« no previous file with comments | « runtime/BUILD.gn ('k') | runtime/third_party/double-conversion/src/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698