Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: content/browser/top_document_isolation_browsertest.cc

Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)
Patch Set: Addressing CR feedback from jkarlin@ and creis@. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/top_document_isolation_browsertest.cc
diff --git a/content/browser/top_document_isolation_browsertest.cc b/content/browser/top_document_isolation_browsertest.cc
index cb57f0681e8bcb2f326a62c29c2ab0f1e8f3ae10..5d5c4d5161741ae3ef7c8a62cb581952df0b94e9 100644
--- a/content/browser/top_document_isolation_browsertest.cc
+++ b/content/browser/top_document_isolation_browsertest.cc
@@ -5,7 +5,6 @@
#include <string>
#include "base/command_line.h"
-#include "base/test/scoped_feature_list.h"
#include "build/build_config.h"
#include "content/browser/frame_host/frame_tree_node.h"
#include "content/browser/web_contents/web_contents_impl.h"
@@ -32,9 +31,9 @@ class TopDocumentIsolationTest : public ContentBrowserTest {
return visualizer_.DepictFrameTree(node);
}
- void SetUp() override {
- scoped_feature_list_.InitAndEnableFeature(features::kTopDocumentIsolation);
- ContentBrowserTest::SetUp();
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ ContentBrowserTest::SetUpCommandLine(command_line);
+ content::EnableTopDocumentIsolationForTesting(command_line);
}
void SetUpOnMainThread() override {
@@ -70,7 +69,6 @@ class TopDocumentIsolationTest : public ContentBrowserTest {
private:
FrameTreeVisualizer visualizer_;
- base::test::ScopedFeatureList scoped_feature_list_;
DISALLOW_COPY_AND_ASSIGN(TopDocumentIsolationTest);
};
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/public/browser/content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698