Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/browser/ui/extensions/hosted_app_browsertest.cc

Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)
Patch Set: Addressing CR feedback from jkarlin@ and creis@. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/hosted_app_browsertest.cc
diff --git a/chrome/browser/ui/extensions/hosted_app_browsertest.cc b/chrome/browser/ui/extensions/hosted_app_browsertest.cc
index 15ae43e01347c820136d9ae475ebbda6ef102714..e5ae235b8d9916983a8d40f1bfe65eecca585ed4 100644
--- a/chrome/browser/ui/extensions/hosted_app_browsertest.cc
+++ b/chrome/browser/ui/extensions/hosted_app_browsertest.cc
@@ -255,15 +255,17 @@ class HostedAppVsTdiTest : public HostedAppTest {
HostedAppVsTdiTest() {}
~HostedAppVsTdiTest() override {}
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ HostedAppTest::SetUpCommandLine(command_line);
+ content::EnableTopDocumentIsolationForTesting(command_line);
+ }
+
void SetUpOnMainThread() override {
- scoped_feature_list_.InitAndEnableFeature(features::kTopDocumentIsolation);
HostedAppTest::SetUpOnMainThread();
ASSERT_TRUE(embedded_test_server()->Start());
}
private:
- base::test::ScopedFeatureList scoped_feature_list_;
-
DISALLOW_COPY_AND_ASSIGN(HostedAppVsTdiTest);
};

Powered by Google App Engine
This is Rietveld 408576698