chrome/browser/extensions/chrome_content_browser_client_extensions_part.h - Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)

Patch Set: Addressing CR feedback from jkarlin@ and creis@. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

diff --git a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

index c4c8b7826bfeed997caf31dfa04a17a7e1205cb6..a69cf10bcdd0f4eb886f7549c362deba3be4c41d 100644

--- a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

+++ b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

@@ -5,6 +5,10 @@

#ifndef CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PART_H_

#define CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PART_H_

+#include <memory>

+#include <string>

+#include <vector>

#include "base/compiler_specific.h"

#include "base/macros.h"

#include "chrome/browser/chrome_content_browser_client_parts.h"

@@ -71,9 +75,8 @@ class ChromeContentBrowserClientExtensionsPart

static std::unique_ptr<content::VpnServiceProxy> GetVpnServiceProxy(

content::BrowserContext* browser_context);

- static bool ShouldFrameShareParentSiteInstanceDespiteTopDocumentIsolation(

- const GURL& url,

- content::SiteInstance* parent_site_instance);

+ static bool IsMainFrameSiteInstanceExcludedFromTopDocumentIsolation(

+ content::SiteInstance* main_frame_site_instance);

private:

FRIEND_TEST_ALL_PREFIXES(ChromeContentBrowserClientExtensionsPartTest,