Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4896)

Unified Diff: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc

Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)
Patch Set: Rebasing on top of r486814 Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
index 710ade67ea35456e90a0d098570fc76535991d96..34e6ab3ba2601f5b4d08cb0bd347626b7fedd23e 100644
--- a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
@@ -11,6 +11,7 @@
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/strings/string_util.h"
+#include "chrome/browser/page_load_metrics/observers/ads_detection.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/render_frame_host.h"
@@ -52,20 +53,9 @@ bool DetectGoogleAd(content::NavigationHandle* navigation_handle) {
content::RenderFrameHost* current_frame_host =
navigation_handle->GetWebContents()->UnsafeFindFrameByFrameTreeNodeId(
navigation_handle->GetFrameTreeNodeId());
- if (current_frame_host) {
- const std::string& frame_name = current_frame_host->GetFrameName();
- if (base::StartsWith(frame_name, "google_ads_iframe",
- base::CompareCase::SENSITIVE) ||
- base::StartsWith(frame_name, "google_ads_frame",
- base::CompareCase::SENSITIVE)) {
- return true;
- }
- }
- const GURL& url = navigation_handle->GetURL();
- return url.host_piece() == "tpc.googlesyndication.com" &&
- base::StartsWith(url.path_piece(), "/safeframe",
- base::CompareCase::SENSITIVE);
+ return IsAdFrame(current_frame_host ? current_frame_host->GetFrameName() : "",
+ navigation_handle->GetURL());
}
void RecordParentExistsForSubFrame(

Powered by Google App Engine
This is Rietveld 408576698