chrome/browser/chrome_content_browser_client.h - Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.h

Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)

Patch Set: Doh... need to also change s/Default/Unspecified/ in chrome_content_browser_client.cc Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_content_browser_client.h

diff --git a/chrome/browser/chrome_content_browser_client.h b/chrome/browser/chrome_content_browser_client.h

index a91a3b0a81e72c26bd6496c8083e366c48a6d3ed..24b079029ab981debb0d82384aafce10f3794f2c 100644

--- a/chrome/browser/chrome_content_browser_client.h

+++ b/chrome/browser/chrome_content_browser_client.h

@@ -111,9 +111,10 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {

ui::PageTransition* transition,

bool* is_renderer_initiated,

content::Referrer* referrer) override;

- bool ShouldFrameShareParentSiteInstanceDespiteTopDocumentIsolation(

- const GURL& url,

- content::SiteInstance* parent_site_instance) override;

+ bool ShouldIsolateFrameForTopDocumentIsolation(

+ content::RenderFrameHost* frame,

+ const GURL& dest_url,

+ content::SiteInstance* main_frame_site_instance) override;

bool IsSuitableHost(content::RenderProcessHost* process_host,

const GURL& site_url) override;

bool MayReuseHost(content::RenderProcessHost* process_host) override;