chrome/browser/BUILD.gn - Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)

Patch Set: Doh... need to also change s/Default/Unspecified/ in chrome_content_browser_client.cc Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index 9196b258ee7b9c2c55ae8796ea554a016c52e3ff..7b005062060ff5d36c05c1ec4e92fed20f49212a 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -821,6 +821,8 @@ split_static_library("browser") {

"page_load_metrics/metrics_web_contents_observer.h",

"page_load_metrics/observers/aborts_page_load_metrics_observer.cc",

"page_load_metrics/observers/aborts_page_load_metrics_observer.h",

+ "page_load_metrics/observers/ads_detection.cc",

+ "page_load_metrics/observers/ads_detection.h",

"page_load_metrics/observers/ads_page_load_metrics_observer.cc",

"page_load_metrics/observers/ads_page_load_metrics_observer.h",

"page_load_metrics/observers/amp_page_load_metrics_observer.cc",