Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: content/browser/top_document_isolation_browsertest.cc

Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)
Patch Set: Use FOR_EACH_TDI_MODE(V) macro. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/top_document_isolation_browsertest.cc
diff --git a/content/browser/top_document_isolation_browsertest.cc b/content/browser/top_document_isolation_browsertest.cc
index be1fa6e4565e9c832525e88effca4441e07634fa..944f8119142944067cc6213a7f513a8570889338 100644
--- a/content/browser/top_document_isolation_browsertest.cc
+++ b/content/browser/top_document_isolation_browsertest.cc
@@ -5,7 +5,6 @@
#include <string>
#include "base/command_line.h"
-#include "base/test/scoped_feature_list.h"
#include "content/browser/frame_host/frame_tree_node.h"
#include "content/browser/web_contents/web_contents_impl.h"
#include "content/public/common/content_features.h"
@@ -31,9 +30,9 @@ class TopDocumentIsolationTest : public ContentBrowserTest {
return visualizer_.DepictFrameTree(node);
}
- void SetUp() override {
- scoped_feature_list_.InitAndEnableFeature(features::kTopDocumentIsolation);
- ContentBrowserTest::SetUp();
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ ContentBrowserTest::SetUpCommandLine(command_line);
+ content::EnableTopDocumentIsolationForTesting(command_line);
}
void SetUpOnMainThread() override {
@@ -69,7 +68,6 @@ class TopDocumentIsolationTest : public ContentBrowserTest {
private:
FrameTreeVisualizer visualizer_;
- base::test::ScopedFeatureList scoped_feature_list_;
DISALLOW_COPY_AND_ASSIGN(TopDocumentIsolationTest);
};

Powered by Google App Engine
This is Rietveld 408576698