content/public/test/DEPS - Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/test/DEPS

Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)

Patch Set: Rebasing... Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "-content",	2 "-content",

3 "+content/public",	3 "+content/public",

4 "+device/geolocation/android/geolocation_jni_registrar.h",	4 "+device/geolocation/android/geolocation_jni_registrar.h",

5 "+mojo/android/system/mojo_jni_registrar.h",	5 "+mojo/android/system/mojo_jni_registrar.h",

6 "+services/service_manager",	6 "+services/service_manager",

7 "+v8/include/v8.h",	7 "+v8/include/v8.h",

	8

	9 # To allow setting feature params for testing via --force-fieldtrial-params.

	10 "+components/variations/variations_switches.h",
	Łukasz Anforowicz 2017/06/30 15:28:37 Needed in this CL by EnableTopDocumentIsolationFor Needed in this CL by EnableTopDocumentIsolationForTesting from content/public/test/test_utils.cc. I think this dependency is okay for test code. Charlie Reis 2017/06/30 23:28:45 I don't have a good sense. We should double check Show quoted text On 2017/06/30 15:28:37, Łukasz A. wrote: > Needed in this CL by EnableTopDocumentIsolationForTesting from > content/public/test/test_utils.cc. I think this dependency is okay for test > code. I don't have a good sense. We should double check with jam@ on this. Łukasz Anforowicz 2017/07/01 00:10:53 Ok. I'll make a note for this. Show quoted text On 2017/06/30 23:28:45, Charlie Reis (OOO til July 5) wrote: > On 2017/06/30 15:28:37, Łukasz A. wrote: > > Needed in this CL by EnableTopDocumentIsolationForTesting from > > content/public/test/test_utils.cc. I think this dependency is okay for test > > code. > > I don't have a good sense. We should double check with jam@ on this. Ok. I'll make a note for this. Łukasz Anforowicz 2017/07/01 00:13:15 jam@ - could you PTAL? Show quoted text On 2017/07/01 00:10:53, Łukasz A. wrote: > On 2017/06/30 23:28:45, Charlie Reis (OOO til July 5) wrote: > > On 2017/06/30 15:28:37, Łukasz A. wrote: > > > Needed in this CL by EnableTopDocumentIsolationForTesting from > > > content/public/test/test_utils.cc. I think this dependency is okay for > test > > > code. > > > > I don't have a good sense. We should double check with jam@ on this. > > Ok. I'll make a note for this. jam@ - could you PTAL?
8 ]	11 ]

9	12

10 # Ensure we don't leak internal content headers through public headers.	13 # Ensure we don't leak internal content headers through public headers.

11 specific_include_rules = {	14 specific_include_rules = {

12 ".*\.(cc\|mm)": [	15 ".*\.(cc\|mm)": [

13 # Allow inclusion of specific components that we depend on.	16 # Allow inclusion of specific components that we depend on.

14 # See comment in content/DEPS for which components are allowed.	17 # See comment in content/DEPS for which components are allowed.

15 "+components/scheduler/renderer",	18 "+components/scheduler/renderer",

16	19

17 # Testing utilities can access anything in content/	20 # Testing utilities can access anything in content/

18 "+content",	21 "+content",

19 "+gin/v8_initializer.h",	22 "+gin/v8_initializer.h",

20 "+third_party/iaccessible2",	23 "+third_party/iaccessible2",

21 "+ui/base/resource/resource_bundle.h",	24 "+ui/base/resource/resource_bundle.h",

22 ],	25 ],

23 }	26 }

OLD	NEW

« content/public/common/content_features.h ('K') | « content/public/common/content_features.cc ('k') | content/public/test/test_utils.h » ('j') | content/test/BUILD.gn » ('J')