chrome/browser/page_load_metrics/observers/ads_detection.h - Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/page_load_metrics/observers/ads_detection.h

Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)

Patch Set: Rebasing... Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ADS_DETECTION_H_

	6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ADS_DETECTION_H_

	7

	8 #include <string>

	9

	10 #include "base/strings/string_piece_forward.h"

	11

	12 class GURL;

	13

	14 // Uses various heuristics to determine if a given frame hosts an advertisment.

	15 bool IsAdFrame(base::StringPiece frame_name, const GURL& frame_url);
	Łukasz Anforowicz 2017/06/30 15:28:37 This function used to be hidden inside an anonymou This function used to be hidden inside an anonymous namespace inside chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc.
	16

	17 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ADS_DETECTION_H_

OLD	NEW