Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Side by Side Diff: chrome/browser/chrome_content_browser_client.h

Issue 2946113002: Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (Closed)
Patch Set: Addressing CR feedback from jkarlin@ and creis@. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
6 #define CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_ 6 #define CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 bool LogWebUIUrl(const GURL& web_ui_url) const override; 105 bool LogWebUIUrl(const GURL& web_ui_url) const override;
106 bool IsHandledURL(const GURL& url) override; 106 bool IsHandledURL(const GURL& url) override;
107 bool CanCommitURL(content::RenderProcessHost* process_host, 107 bool CanCommitURL(content::RenderProcessHost* process_host,
108 const GURL& url) override; 108 const GURL& url) override;
109 bool ShouldAllowOpenURL(content::SiteInstance* site_instance, 109 bool ShouldAllowOpenURL(content::SiteInstance* site_instance,
110 const GURL& url) override; 110 const GURL& url) override;
111 void OverrideNavigationParams(content::SiteInstance* site_instance, 111 void OverrideNavigationParams(content::SiteInstance* site_instance,
112 ui::PageTransition* transition, 112 ui::PageTransition* transition,
113 bool* is_renderer_initiated, 113 bool* is_renderer_initiated,
114 content::Referrer* referrer) override; 114 content::Referrer* referrer) override;
115 bool ShouldFrameShareParentSiteInstanceDespiteTopDocumentIsolation( 115 bool ShouldIsolateFrameForTopDocumentIsolation(
116 const GURL& url, 116 content::NavigationHandle* navigation_handle,
117 content::SiteInstance* parent_site_instance) override; 117 content::SiteInstance* main_frame_site_instance) override;
118 bool IsSuitableHost(content::RenderProcessHost* process_host, 118 bool IsSuitableHost(content::RenderProcessHost* process_host,
119 const GURL& site_url) override; 119 const GURL& site_url) override;
120 bool MayReuseHost(content::RenderProcessHost* process_host) override; 120 bool MayReuseHost(content::RenderProcessHost* process_host) override;
121 bool ShouldTryToUseExistingProcessHost( 121 bool ShouldTryToUseExistingProcessHost(
122 content::BrowserContext* browser_context, 122 content::BrowserContext* browser_context,
123 const GURL& url) override; 123 const GURL& url) override;
124 void SiteInstanceGotProcess(content::SiteInstance* site_instance) override; 124 void SiteInstanceGotProcess(content::SiteInstance* site_instance) override;
125 void SiteInstanceDeleting(content::SiteInstance* site_instance) override; 125 void SiteInstanceDeleting(content::SiteInstance* site_instance) override;
126 bool ShouldSwapBrowsingInstancesForNavigation( 126 bool ShouldSwapBrowsingInstancesForNavigation(
127 content::SiteInstance* site_instance, 127 content::SiteInstance* site_instance,
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 std::unique_ptr< 406 std::unique_ptr<
407 service_manager::BinderRegistryWithArgs<content::RenderFrameHost*>> 407 service_manager::BinderRegistryWithArgs<content::RenderFrameHost*>>
408 frame_interfaces_parameterized_; 408 frame_interfaces_parameterized_;
409 409
410 base::WeakPtrFactory<ChromeContentBrowserClient> weak_factory_; 410 base::WeakPtrFactory<ChromeContentBrowserClient> weak_factory_;
411 411
412 DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClient); 412 DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClient);
413 }; 413 };
414 414
415 #endif // CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_ 415 #endif // CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
OLDNEW
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698