Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2946103002: Add KeyboardEventCodeInteractiveTest

Created:
3 years, 6 months ago by Hzj_jie
Modified:
3 years, 6 months ago
Reviewers:
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add KeyboardEventCodeInteractiveTest to test ui_test_utils::SendKeyPressSync() KeyboardEventCodeInteractiveTest starts a web page to record all the KeyboardEvent.code it received, sends several key presses through ui_test_utils::SendKeyPressSync() and verifies whether the record is expected. This test ensures KeyboardEvent.code can be correctly set by using ui_test_utils::SendKeyPressSync() function. After change https://codereview.chromium.org/2939283002/, this test should pass on all platforms. BUG=680809

Patch Set 1 : This iteration is expected to success on Windows as https://codereview.chromium.org/2939283002/ is merged #

Patch Set 2 : This iteration is expected to fail on Windows as https://codereview.chromium.org/2939283002/ is req… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -0 lines) Patch
A chrome/browser/keyboardevent_code_interactive_browsertest.cc View 1 chunk +89 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/keyboardevent_code_test.html View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (17 generated)
Hzj_jie
3 years, 6 months ago (2017-06-21 00:42:24 UTC) #17

          

Powered by Google App Engine
This is Rietveld 408576698