Issue 2946017: Send large dump file for canary build. Also fix a similar...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2946017: Send large dump file for canary build. Also fix a similar... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by huanr

Modified:
3 years, 5 months ago

Reviewers:
mattm

CC:
chromium-reviews, Raghu Simha, ncarter, ben+cc_chromium.org, timsteele, idana

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Send large dump file for canary build. Also fix a similar error in comments. BUG=49085 TEST="about:crash" in canary build. The dump file should be of large dump type. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52488

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/app/breakpad_win.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	chrome/browser/sync/profile_sync_service.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Trybot results: linux mac win

Total messages: 4 (0 generated)

mattm

Sorry, what does "Also fix a similar error in bugs." refer to?

4 years, 10 months ago (2010-07-14 20:23:13 UTC) #2

huanr

On 2010/07/14 20:23:13, mattm wrote: > Sorry, what does "Also fix a similar error in ...

4 years, 10 months ago (2010-07-14 20:31:21 UTC) #3

lgtm