Introduce create_nonsfi_test_nmf.py to simplify nacl_test_data.gyp

chrome/test/data/nacl/nacl_test_data.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
     '../../../../ppapi/ppapi_nacl_test_common.gypi',
   ],
   'targets': [
     {
       'target_name': 'shared_test_files',
       'type': 'none',
       'variables': {
         'build_newlib': 1,
         'build_glibc': 1,
         'build_pnacl_newlib': 1,
         'nexe_destination_dir': 'nacl_test_data',
         'test_files': [
           # TODO(ncbray) move into chrome/test/data/nacl when all tests are
           # converted.
           '<(DEPTH)/ppapi/native_client/tests/ppapi_browser/progress_event_listener.js',
           '<(DEPTH)/ppapi/native_client/tools/browser_tester/browserdata/nacltest.js',
+
           # Files that aren't assosiated with any particular executable.
           'bad/ppapi_bad.html',
           'bad/ppapi_bad.js',
           'bad/ppapi_bad_native.html',
           'bad/ppapi_bad_doesnotexist.nmf',
           'bad/ppapi_bad_magic.nmf',
           'bad/ppapi_bad_manifest_uses_nexes.nmf',
           'bad/ppapi_bad_manifest_bad_files.nmf',
           'bad/ppapi_bad_manifest_nexe_arch.nmf',
           'crash/ppapi_crash.html',
           'load_util.js',
           'manifest_file/test_file.txt',
         ],
       },
+      'conditions': [
+        ['target_arch=="ia32" and OS=="linux"', {
+          # Enable nonsfi testing only on ia32-linux environment.
+          # By this flag, test_files are copied into nonsfi directory, too.

[Mark Seaborn, 2014/05/19 18:55:29]

Maybe "This flag causes test_files to be copied..."?

[hidehiko, 2014/05/20 05:51:47]

Done.

+          'variables': {
+            'enable_x86_32_nonsfi': 1,
+          },
+        }],
+      ],
     },
     {
       'target_name': 'simple_test',
       'type': 'none',
       'variables': {
         'nexe_target': 'simple',
         'build_newlib': 1,
         'build_glibc': 1,
         'build_pnacl_newlib': 1,
         'nexe_destination_dir': 'nacl_test_data',
@@ skipping 563 matching lines @@
         '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
         '<(DEPTH)/native_client/src/shared/srpc/srpc.gyp:srpc_lib',
         '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
         '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
         '<(DEPTH)/native_client/src/shared/imc/imc.gyp:imc_lib',
         '<(DEPTH)/native_client/src/untrusted/nacl/nacl.gyp:imc_syscalls_lib',
         '<(DEPTH)/native_client/src/untrusted/nacl/nacl.gyp:nacl_lib',
         '<(DEPTH)/native_client/src/trusted/weak_ref/weak_ref.gyp:weak_ref_lib',
         'nacl_ppapi_util',
       ],
+      'conditions': [
+        ['target_arch=="ia32" and OS=="linux"', {
+          # Enable nonsfi testing only on ia32-linux environment.
+          'variables': {
+            # This is needed to build a non-SFI nexe binary.
+            # Note that this triggers building nexe files for other
+            # architecture, such as x86-32 (based on enable_XXX variables).

[Mark Seaborn, 2014/05/19 18:55:29]

"architectures" plural

[hidehiko, 2014/05/20 05:51:47]

Done.

+            # As described above, although the tests for pnacl are currently
+            # disabled, but building the binary should work.
+            # We cannot disable building, as enable_XXX variables are also used
+            # to build newlib linked nexes.

[hidehiko, 2014/05/19 14:51:35]

FYI: generating unnecessary nexe files is what other tests do, so it should
work.

+            'build_pnacl_newlib': 1,
+            'enable_x86_32_nonsfi': 1,
+          },
+        }],
+      ],
     },
     {
       'target_name': 'irt_exception_test',
       'type': 'none',
       'variables': {
         'nexe_target': 'irt_exception_test',
         'build_newlib': 1,
         'generate_nmf': 1,
         'nexe_destination_dir': 'nacl_test_data',
         'build_pnacl_newlib': 1,
         'nonsfi_destination_dir': '<(PRODUCT_DIR)/>(nexe_destination_dir)/nonsfi',

[Mark Seaborn, 2014/05/19 18:55:29]

Shouldn't this go away too?

[hidehiko, 2014/05/20 05:51:47]

Good catch. Done.

         # Workaround because generate_nmf doesn't work yet for NonSFI,

[Mark Seaborn, 2014/05/19 18:55:29]

Remove this comment?

[hidehiko, 2014/05/20 05:51:47]

Done.

         # explicitly specify the destination directory for NonSFI so
         # that we don't have to move it around.
-        'out_pnacl_newlib_x86_32_nonsfi_nexe': '>(nonsfi_destination_dir)/irt_exception_test_pnacl_newlib_x32_nonsfi.nexe',
         'link_flags': [
           '-lppapi',
           '-lppapi_test_lib',
           '-lplatform',
           '-lgio',
           '-lnacl_exception',
         ],
         'sources': [
           'irt_exception/irt_exception_test.cc',
         ],
         'test_files': [
           # TODO(ncbray) move into chrome/test/data/nacl when all tests are
           # converted.
           'irt_exception/irt_exception_test.html',
         ],
       },
       'dependencies': [
         '<(DEPTH)/native_client/tools.gyp:prep_toolchain',
         '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
         '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
         '<(DEPTH)/native_client/src/untrusted/nacl/nacl.gyp:nacl_exception_lib',
         '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
         '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
         'ppapi_test_lib',
       ],
       'conditions': [
-        ['disable_pnacl==0 and target_arch=="ia32" and OS=="linux"', {
+        ['target_arch=="ia32" and OS=="linux"', {
+          # Enable nonsfi testing only on ia32-linux environment.
           'variables': {
             'enable_x86_32_nonsfi': 1,
-            # Files specifically for NonSFI NaCl. nmf file is
-            # hand-crafted until generate_nmf learns about NonSFI
-            # case, and generate_nmf is the one who usually copies
-            # those files.
-            'nonsfi_test_files': [
-              # TODO(ncbray) move into chrome/test/data/nacl when all tests are
-              # converted.
-              '<(DEPTH)/ppapi/native_client/tools/browser_tester/browserdata/nacltest.js',
-              'irt_exception/irt_exception_test.html',
-              'irt_exception/irt_exception_test.nmf',
-            ],
           },
-          'copies': [
-            {
-              'destination': '>(nonsfi_destination_dir)',
-              'files': [
-                '>@(nonsfi_test_files)',
-              ],
-            },
-          ],
         }],
       ],
     },
     {
       'target_name': 'pm_nameservice_test',
       'type': 'none',
       'variables': {
         'nexe_target': 'pm_nameservice_test',
         'build_newlib': 1,
         'build_glibc': 1,
@@ skipping 469 matching lines @@
           # testing environment here.
           'copies': [
             {
               'destination': '>(destination_dir)',
               'files': [
                 '>@(test_files)',
               ],
             },
           ],
         },
-        {
-          'target_name': 'nonsfi_irt_manifest_file',
-          'type': 'none',
-          'variables': {
-            'nexe_target': 'irt_manifest_file',
-            'enable_x86_32': 0,
-            'enable_x86_64': 0,
-            'enable_x86_32_nonsfi': 1,
-            'build_pnacl_newlib': 1,
-            # create_nmf.py doesn't support nonsfi.
-            # TODO(crbug.com/368949): Clean this up after nonsfi support on
-            # create_nmf.py.
-            'generate_nmf': 0,
-            'nexe_destination_dir': 'nacl_test_data',
-            'link_flags': [
-              '-lnacl_ppapi_util',
-              '-lppapi_cpp',
-              '-lppapi',
-              '-lnacl',
-            ],
-            'sources': [
-              'manifest_file/irt_manifest_file_test.cc',
-            ],
-            'test_files': [
-              # TODO(ncbray) move into chrome/test/data/nacl when all tests are
-              # converted.
-              '<(DEPTH)/ppapi/native_client/tools/browser_tester/browserdata/nacltest.js',
-              'manifest_file/irt_manifest_file.nmf',
-              'manifest_file/irt_manifest_file_test.html',
-              'manifest_file/test_file.txt',
-            ],
-          },
-          'dependencies': [
-            '<(DEPTH)/native_client/tools.gyp:prep_toolchain',
-            '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
-            '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
-            '<(DEPTH)/native_client/src/untrusted/nacl/nacl.gyp:nacl_lib',
-            'nacl_ppapi_util',
-          ],
-        },
       ],
     }],
   ],
 }