Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: content/browser/service_worker/service_worker_utils_unittest.cc

Issue 294593002: ServiceWorker: Support longest-prefix-match for registration scope (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_utils_unittest.cc
diff --git a/content/browser/service_worker/service_worker_utils_unittest.cc b/content/browser/service_worker/service_worker_utils_unittest.cc
index d6e0ba1a02c12f6f136810d468b4862836919038..67a74801d6cfb4318f5afb5c868424acabf3391c 100644
--- a/content/browser/service_worker/service_worker_utils_unittest.cc
+++ b/content/browser/service_worker/service_worker_utils_unittest.cc
@@ -69,4 +69,35 @@ TEST(ServiceWorkerUtilsTest, ScopeMatches) {
GURL("http://www.example.com/\\*"), GURL("http://www.example.com/\\x")));
}
+TEST(ServiceWorkerUtilsTest, FindLongestScopeMatch_Basic) {
+ LongestScopeMatcher matcher(GURL("http://www.example.com/xxx"));
+
+ // "/xx*" should be matched longest.
+ ASSERT_TRUE(matcher.MatchLongest(GURL("http://www.example.com/x*")));
+ ASSERT_FALSE(matcher.MatchLongest(GURL("http://www.example.com/*")));
+ ASSERT_TRUE(matcher.MatchLongest(GURL("http://www.example.com/xx*")));
+
+ // "xxx*" should be matched longer than "/xx*".
+ ASSERT_TRUE(matcher.MatchLongest(GURL("http://www.example.com/xxx*")));
+
+ ASSERT_FALSE(matcher.MatchLongest(GURL("http://www.example.com/xxxx*")));
+}
+
+TEST(ServiceWorkerUtilsTest, FindLongestScopeMatch_SameLength) {
+ LongestScopeMatcher matcher1(GURL("http://www.example.com/xxx"));
+
+ // "/xxx" has the same length with "/xx*", so they are compared as strings
+ // and "/xxx" should win.
+ // TODO(nhiroki): This isn't in the spec (see: service_worker_utils.cc)
+ ASSERT_TRUE(matcher1.MatchLongest(GURL("http://www.example.com/xxx")));
+ ASSERT_FALSE(matcher1.MatchLongest(GURL("http://www.example.com/xx*")));
+
+ LongestScopeMatcher matcher2(GURL("http://www.example.com/x(1)"));
+
+ // "/xx*" should be prioritized over "/x(1)".
+ // TODO(nhiroki): This isn't in the spec (see: service_worker_utils.cc)
+ ASSERT_TRUE(matcher2.MatchLongest(GURL("http://www.example.com/x(1)")));
+ ASSERT_TRUE(matcher2.MatchLongest(GURL("http://www.example.com/x(1*")));
+}
+
} // namespace content
« no previous file with comments | « content/browser/service_worker/service_worker_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698