chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java - Issue 2945903002: Rendering the image in the sandbox for security

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

Issue 2945903002: Rendering the image in the sandbox for security (Closed)

Patch Set: comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java ('k') | chrome/browser/ui/android/context_menu_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

index 36284a63312a337f2965ee20b0c8ac04a77b6cb8..6e11f9688527f5befe7ab22b47abcadfd71026ea 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

@@ -273,7 +273,11 @@ public class TabularContextMenuUi implements ContextMenuUi, AdapterView.OnItemCl

public void onImageThumbnailRetrieved(Bitmap bitmap) {

if (mHeaderImageView != null) {

- mHeaderImageView.setImageBitmap(bitmap);

+ if (bitmap != null) {

+ mHeaderImageView.setImageBitmap(bitmap);

+ } else {

+ mHeaderImageView.setImageResource(R.drawable.sad_tab);

+ }

}