Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2506)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

Issue 2945903002: Rendering the image in the sandbox for security (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
index 7a7e5c125a29017108dab2dbfb3e6060d42b70d0..15e06be2c6c51b75f4df2dbc7735f63a983b6e6c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
@@ -279,7 +279,11 @@ public class TabularContextMenuUi implements ContextMenuUi, AdapterView.OnItemCl
*/
public void onImageThumbnailRetrieved(Bitmap bitmap) {
if (mHeaderImageView != null) {
- mHeaderImageView.setImageBitmap(bitmap);
+ if (bitmap != null) {
+ mHeaderImageView.setImageBitmap(bitmap);
+ } else {
+ mHeaderImageView.setImageResource(R.drawable.sad_tab);
gone 2017/06/20 00:32:39 Any reason you picked sad tab? Is it in the mock?
Daniel Park 2017/06/21 00:01:23 Acknowledged.
Ted C 2017/06/21 00:18:02 Nit, but what are you acknowledging? I would give
Daniel Park 2017/06/22 00:54:09 Got it. I talked with Dan offline about it, and th
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698