Use ContainsValue() instead of std::find() in ios/

ios/web/webui/url_data_manager_ios.cc

Index: ios/web/webui/url_data_manager_ios.cc
diff --git a/ios/web/webui/url_data_manager_ios.cc b/ios/web/webui/url_data_manager_ios.cc
index 8cb9a5413cd983f298fe48e91ae914d3caffb47f..fb9689f4ab78c98683f0a41338e724988f13e370 100644
--- a/ios/web/webui/url_data_manager_ios.cc
+++ b/ios/web/webui/url_data_manager_ios.cc
@@ -13,6 +13,7 @@
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/message_loop/message_loop.h"
+#include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/synchronization/lock.h"
 #include "ios/web/public/browser_state.h"
@@ -129,8 +130,7 @@ bool URLDataManagerIOS::IsScheduledForDeletion(
   base::AutoLock lock(g_delete_lock.Get());
   if (!data_sources_)
     return false;
-  return std::find(data_sources_->begin(), data_sources_->end(), data_source) !=
-         data_sources_->end();
+  return base::ContainsValue(data_sources_, data_source);

[sdefresne, 2017/06/27 09:34:37]

data_sources_ is a pointer, base::ContainsValue uses std::begin/std::end but I
don't see any overload that work with a pointer to a collection (according to
http://en.cppreference.com/w/cpp/iterator/begin). I don't see an overload for
base::ContainsValue that takes a pointer to a container.

So I'm surprised this compile and instead I would have expected this to be the
following:

  return base::ContainsValue(*data_sources_, data_source);

Indeed, when I try to apply this change, I get the following compilation error:

../../base/stl_util.h:90:20: error: no matching function for call to 'begin'
  return std::find(std::begin(collection), std::end(collection), value) !=
                   ^~~~~~~~~~

[Tripta, 2017/06/28 07:39:33]

Done.

 }
 
 }  // namespace web