Use ContainsValue() instead of std::find() in ios/

ios/chrome/browser/passwords/password_generation_agent.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/passwords/password_generation_agent.h"
 
 #include <stddef.h>
 
 #include "base/mac/foundation_util.h"
 #include "base/mac/scoped_block.h"
+#include "base/stl_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/password_generator.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/autofill/core/common/password_generation_util.h"
 #import "components/autofill/ios/browser/js_suggestion_manager.h"
 #include "components/password_manager/core/browser/password_manager.h"
 #include "google_apis/gaia/gaia_urls.h"
 #import "ios/chrome/browser/autofill/form_input_accessory_view_controller.h"
@@ skipping 15 matching lines @@
 namespace {
 
 // Target length of generated passwords.
 const int kGeneratedPasswordLength = 20;
 
 // The minimum number of text fields that a form needs to be considered as
 // an account creation form.
 const size_t kMinimumTextFieldsForAccountCreation = 3;
 
 // Returns true if |urls| contains |url|.
 bool VectorContainsURL(const std::vector<GURL>& urls, const GURL& url) {

[sdefresne, 2017/06/23 14:31:21]

There is only one call site for VectorContainsURL (in the current file). Maybe
inline the base::ContainsValue() and remove the function (as it is just a
specialized instantiation of base::ContainsValue).

[Tripta, 2017/06/27 06:41:28]

Done.

-  return std::find(urls.begin(), urls.end(), url) != urls.end();
+  return base::ContainsValue(urls, url);
 }
 
 // Returns whether |field| should be considered a text field. Implementation
 // mirrors that of password_controller.js.
 // TODO(crbug.com/433856): Figure out how to determine if |field| is visible.
 bool IsTextField(const autofill::FormFieldData& field) {
   return field.form_control_type == "text" ||
          field.form_control_type == "email" ||
          field.form_control_type == "number" ||
          field.form_control_type == "tel" || field.form_control_type == "url" ||
@@ skipping 378 matching lines @@
   DCHECK(_accessoryViewReadyCompletion);
   _accessoryViewReadyCompletion([self currentAccessoryView], self);
 }
 
 - (BOOL)getLogKeyboardAccessoryMetrics {
   // Only store metrics for regular Autofill, not passwords.
   return NO;
 }
 
 @end