Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4827)

Unified Diff: chrome/browser/chromeos/printer_detector/printer_detector.h

Issue 2945653002: Remove the legacy (extension-notifier) usb printer detector. Rename the remaining printerdetector … (Closed)
Patch Set: Remove the legacy (extension-notifier) usb printer detector. Rename the remaining printerdetector … Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/printer_detector/printer_detector.h
diff --git a/chrome/browser/chromeos/printer_detector/printer_detector.h b/chrome/browser/chromeos/printer_detector/printer_detector.h
deleted file mode 100644
index 1789377df473c48e3d70b2087bfaa11f7f732854..0000000000000000000000000000000000000000
--- a/chrome/browser/chromeos/printer_detector/printer_detector.h
+++ /dev/null
@@ -1,79 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_CHROMEOS_PRINTER_DETECTOR_PRINTER_DETECTOR_H_
-#define CHROME_BROWSER_CHROMEOS_PRINTER_DETECTOR_PRINTER_DETECTOR_H_
-
-#include <memory>
-#include <string>
-#include <vector>
-
-#include "base/macros.h"
-#include "chromeos/printing/printer_configuration.h"
-#include "components/keyed_service/core/keyed_service.h"
-
-class NotificationUIManager;
-class Profile;
-
-namespace chromeos {
-
-// Observes device::UsbService for addition of USB printers (devices with
-// interface class 7). What it does with this depends on whether or not
-// CUPS printing support is enabled.
-//
-// If CUPS is disabled, the Legacy implementation should be used. The legacy
-// implementation shows a notification depending on whether there are printer
-// provider apps that declared support for the USB device installed. If such
-// app exists, the notification notifies the user the printer is ready.
-// Otherwise the notification offers user to search Chrome Web Store for apps
-// that support the printer. Clicking the notification launches webstore_widget
-// app for the printer. The notification is shown only for active user's
-// profile.
-//
-// If CUPS is enabled, the Cups implementation should be used. This
-// implementation to guides the user through setting up a new USB printer in the
-// CUPS backend.
-class PrinterDetector : public KeyedService {
- public:
- class Observer {
- public:
- virtual ~Observer() = default;
-
- // The set of available printers has changed.
- virtual void OnAvailableUsbPrintersChanged(
- const std::vector<Printer>& printers) = 0;
- };
-
- // Factory function for the Legacy implementation.
- static std::unique_ptr<PrinterDetector> CreateLegacy(Profile* profile);
-
- // Factory function for the CUPS implementation.
- static std::unique_ptr<PrinterDetector> CreateCups(Profile* profile);
- ~PrinterDetector() override {}
-
- // Observer management. Note these are only implemented for the cups backend.
- // TODO(justincarlson) - Change these all to pure virtual functions when the
- // legacy backend is retired.
-
- virtual void AddObserver(Observer* observer) {}
- virtual void RemoveObserver(Observer* observer) {}
-
- // Get the current set of detected printers.
- virtual std::vector<Printer> GetPrinters();
-
- protected:
- PrinterDetector() = default;
-
- private:
- friend class PrinterDetectorAppSearchEnabledTest;
-
- virtual void SetNotificationUIManagerForTesting(
- NotificationUIManager* manager) = 0;
-
- DISALLOW_COPY_AND_ASSIGN(PrinterDetector);
-};
-
-} // namespace chromeos
-
-#endif // CHROME_BROWSER_CHROMEOS_PRINTER_DETECTOR_PRINTER_DETECTOR_H_

Powered by Google App Engine
This is Rietveld 408576698