chromeos/components/tether/initializer.cc - Issue 2945643002: [CrOS Tether] Sort Tether network lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/components/tether/initializer.cc

Issue 2945643002: [CrOS Tether] Sort Tether network lists. (Closed)

Patch Set: Order active networks before non-active. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/components/tether/host_scan_device_prioritizer_impl.cc ('K') | « chromeos/components/tether/host_scanner_unittest.cc ('k') | chromeos/components/tether/mock_host_scan_device_prioritizer.h » ('j') | chromeos/network/network_state_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/components/tether/initializer.cc

diff --git a/chromeos/components/tether/initializer.cc b/chromeos/components/tether/initializer.cc

index fe1ed4f0c4e1ea4bd7ab093381ca36b86f358747..556b5831713b2ac36fa41d2415337f4c21a24cfb 100644

--- a/chromeos/components/tether/initializer.cc

+++ b/chromeos/components/tether/initializer.cc

@@ -10,7 +10,7 @@

#include "chromeos/components/tether/ble_connection_manager.h"

#include "chromeos/components/tether/device_id_tether_network_guid_map.h"

#include "chromeos/components/tether/host_scan_cache.h"

-#include "chromeos/components/tether/host_scan_device_prioritizer.h"

+#include "chromeos/components/tether/host_scan_device_prioritizer_impl.h"

#include "chromeos/components/tether/host_scan_scheduler.h"

#include "chromeos/components/tether/host_scanner.h"

#include "chromeos/components/tether/keep_alive_scheduler.h"

@@ -183,8 +183,12 @@ void Initializer::OnBluetoothAdapterAdvertisingIntervalSet(

cryptauth::BluetoothThrottlerImpl::GetInstance());

tether_host_response_recorder_ =

base::MakeUnique<TetherHostResponseRecorder>(pref_service_);

- host_scan_device_prioritizer_ = base::MakeUnique<HostScanDevicePrioritizer>(

- tether_host_response_recorder_.get());

+ device_id_tether_network_guid_map_ =

+ base::MakeUnique<DeviceIdTetherNetworkGuidMap>();

+ host_scan_device_prioritizer_ =

+ base::MakeUnique<HostScanDevicePrioritizerImpl>(

+ network_state_handler_, tether_host_response_recorder_.get(),

+ device_id_tether_network_guid_map_.get());

wifi_hotspot_connector_ = base::MakeUnique<WifiHotspotConnector>(

network_state_handler_, network_connect_);

active_host_ =

@@ -192,8 +196,6 @@ void Initializer::OnBluetoothAdapterAdvertisingIntervalSet(

active_host_network_state_updater_ =

base::MakeUnique<ActiveHostNetworkStateUpdater>(active_host_.get(),

network_state_handler_);

- device_id_tether_network_guid_map_ =

- base::MakeUnique<DeviceIdTetherNetworkGuidMap>();

host_scan_cache_ = base::MakeUnique<HostScanCache>(

network_state_handler_, active_host_.get(),

tether_host_response_recorder_.get(),