Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chromeos/components/tether/host_scan_device_prioritizer_unittest.cc

Issue 2945643002: [CrOS Tether] Sort Tether network lists. (Closed)
Patch Set: stevenjb@ comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/components/tether/host_scan_device_prioritizer_unittest.cc
diff --git a/chromeos/components/tether/host_scan_device_prioritizer_unittest.cc b/chromeos/components/tether/host_scan_device_prioritizer_unittest.cc
deleted file mode 100644
index 1a1846d857a9459fe3e6a4b9829ccf1ed43d7aab..0000000000000000000000000000000000000000
--- a/chromeos/components/tether/host_scan_device_prioritizer_unittest.cc
+++ /dev/null
@@ -1,120 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chromeos/components/tether/host_scan_device_prioritizer.h"
-
-#include "chromeos/components/tether/tether_host_response_recorder.h"
-#include "components/cryptauth/remote_device_test_util.h"
-#include "components/prefs/testing_pref_service.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace chromeos {
-
-namespace tether {
-
-class HostScanDevicePrioritizerTest : public testing::Test {
- protected:
- HostScanDevicePrioritizerTest()
- : test_devices_(cryptauth::GenerateTestRemoteDevices(10)) {}
-
- void SetUp() override {
- pref_service_ = base::MakeUnique<TestingPrefServiceSimple>();
- TetherHostResponseRecorder::RegisterPrefs(pref_service_->registry());
-
- recorder_ =
- base::MakeUnique<TetherHostResponseRecorder>(pref_service_.get());
-
- prioritizer_ = base::MakeUnique<HostScanDevicePrioritizer>(recorder_.get());
- }
-
- const std::vector<cryptauth::RemoteDevice> test_devices_;
-
- std::unique_ptr<TestingPrefServiceSimple> pref_service_;
- std::unique_ptr<TetherHostResponseRecorder> recorder_;
-
- std::unique_ptr<HostScanDevicePrioritizer> prioritizer_;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(HostScanDevicePrioritizerTest);
-};
-
-TEST_F(HostScanDevicePrioritizerTest, TestOnlyTetherAvailabilityResponses) {
- // Receive TetherAvailabilityResponses from devices 0-4.
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[0]);
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[1]);
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[2]);
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[3]);
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[4]);
-
- // Do not receive a ConnectTetheringResponse.
-
- std::vector<cryptauth::RemoteDevice> test_vector =
- std::vector<cryptauth::RemoteDevice>{test_devices_[6], test_devices_[5],
- test_devices_[4], test_devices_[3],
- test_devices_[2], test_devices_[1],
- test_devices_[0]};
-
- prioritizer_->SortByHostScanOrder(&test_vector);
- EXPECT_EQ((std::vector<cryptauth::RemoteDevice>{
- test_devices_[4], test_devices_[3], test_devices_[2],
- test_devices_[1], test_devices_[0], test_devices_[6],
- test_devices_[5]}),
- test_vector);
-}
-
-TEST_F(HostScanDevicePrioritizerTest, TestBothTypesOfResponses) {
- // Receive TetherAvailabilityResponses from devices 0-4.
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[0]);
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[1]);
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[2]);
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[3]);
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[4]);
-
- // Receive ConnectTetheringResponse from device 0.
- recorder_->RecordSuccessfulConnectTetheringResponse(test_devices_[0]);
-
- std::vector<cryptauth::RemoteDevice> test_vector =
- std::vector<cryptauth::RemoteDevice>{test_devices_[6], test_devices_[5],
- test_devices_[4], test_devices_[3],
- test_devices_[2], test_devices_[1],
- test_devices_[0]};
-
- prioritizer_->SortByHostScanOrder(&test_vector);
- EXPECT_EQ((std::vector<cryptauth::RemoteDevice>{
- test_devices_[0], test_devices_[4], test_devices_[3],
- test_devices_[2], test_devices_[1], test_devices_[6],
- test_devices_[5]}),
- test_vector);
-}
-
-TEST_F(HostScanDevicePrioritizerTest, TestBothTypesOfResponses_DifferentOrder) {
- // Receive different order.
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[0]);
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[2]);
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[1]);
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[4]);
- recorder_->RecordSuccessfulTetherAvailabilityResponse(test_devices_[3]);
-
- // Receive ConnectTetheringResponse from device 1.
- recorder_->RecordSuccessfulConnectTetheringResponse(test_devices_[1]);
-
- std::vector<cryptauth::RemoteDevice> test_vector =
- std::vector<cryptauth::RemoteDevice>{test_devices_[9], test_devices_[8],
- test_devices_[7], test_devices_[6],
- test_devices_[5], test_devices_[4],
- test_devices_[3], test_devices_[2],
- test_devices_[1], test_devices_[0]};
-
- prioritizer_->SortByHostScanOrder(&test_vector);
- EXPECT_EQ((std::vector<cryptauth::RemoteDevice>{
- test_devices_[1], test_devices_[3], test_devices_[4],
- test_devices_[2], test_devices_[0], test_devices_[9],
- test_devices_[8], test_devices_[7], test_devices_[6],
- test_devices_[5]}),
- test_vector);
-}
-
-} // namespace tether
-
-} // namespace cryptauth

Powered by Google App Engine
This is Rietveld 408576698