Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2945603002: Fix infer_instance_accessor_ref test (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix infer_instance_accessor_ref test The test contained a typo which caused `dynamic` to be inferred by accident. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/b513e88de82e0fd62d3a3f1683bb4bb1b2134b2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M pkg/front_end/testcases/inference_new/infer_instance_accessor_ref.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference_new/infer_instance_accessor_ref.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference_new/infer_instance_accessor_ref.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference_new/infer_instance_accessor_ref.dart.strong.expect View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-16 12:54:00 UTC) #2
ahe
lgtm
3 years, 6 months ago (2017-06-16 12:56:42 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as b513e88de82e0fd62d3a3f1683bb4bb1b2134b2a (presubmit successful).
3 years, 6 months ago (2017-06-16 14:04:19 UTC) #5
Siggi Cherem (dart-lang)
3 years, 6 months ago (2017-06-16 16:36:50 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698