components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h - Issue 2945563003: AutofillSaveCardInfoBar on mobile should not appear when legal messages don't parse correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h

Issue 2945563003: AutofillSaveCardInfoBar on mobile should not appear when legal messages don't parse correctly (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc ('K') | « components/autofill/core/browser/autofill_metrics.h ('k') | components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc » ('j') | components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h

diff --git a/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h b/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h

index d1a0d2297b8be651f8e53a7ce59c01caeab6f5d2..93bd99d13fd11372708f8c2af28cfd90aee2aa37 100644

--- a/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h

+++ b/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h

@@ -45,6 +45,9 @@ class AutofillSaveCardInfoBarDelegateMobile : public ConfirmInfoBarDelegate {

// Called when a link in the legal message text was clicked.

void OnLegalMessageLinkClicked(GURL url);

+ // Ensures the InfoBar is not shown if legal messages failed to parse.

Mathieu 2017/06/20 00:36:21 maybe note that legal messages are only specified

Jared Saul 2017/06/20 20:51:27 Done.

+ bool LegalMessagesParsedSuccessfully();

// ConfirmInfoBarDelegate:

int GetIconId() const override;

base::string16 GetMessageText() const override;