MD Bookmarks: Add a confirmation dialog before opening many tabs

chrome/browser/resources/md_bookmarks/command_manager.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Element which shows context menus and handles keyboard
  * shortcuts.
  */
 cr.define('bookmarks', function() {
 
@@ skipping 19 matching lines @@
             Command.OPEN_INCOGNITO,
           ];
         },
       },
 
       /** @private {Set<string>} */
       menuIds_: Object,
 
       /** @private */
       globalCanEdit_: Boolean,
+
+      /** @private */
+      confirmOpenString_: String,
     },
 
+    /** @private {?Function} */
+    confirmOpenCallback_: null,
+
     attached: function() {
       assert(CommandManager.instance_ == null);
       CommandManager.instance_ = this;
 
       this.watch('globalCanEdit_', function(state) {
         return state.prefs.canEdit;
       });
       this.updateFromStore();
 
       /** @private {function(!Event)} */
@@ skipping 256 matching lines @@
           currentId = assert(nodes[currentId].parentId);
           if (itemIds.has(currentId))
             return;
         }
         minimizedSet.add(itemId);
       });
       return minimizedSet;
     },
 
     /**
+     * Open the given |urls| in response to a |command|. May show a confirmation
+     * dialog before opening large numbers of URLs.
      * @param {!Array<string>} urls
      * @param {Command} command
      * @private
      */
     openUrls_: function(urls, command) {
       assert(
           command == Command.OPEN || command == Command.OPEN_NEW_TAB ||
           command == Command.OPEN_NEW_WINDOW ||
           command == Command.OPEN_INCOGNITO);
 
       if (urls.length == 0)
         return;
 
-      var incognito = command == Command.OPEN_INCOGNITO;
-      if (command == Command.OPEN_NEW_WINDOW || incognito) {
-        chrome.windows.create({url: urls, incognito: incognito});
-      } else {
-        if (command == Command.OPEN)
-          chrome.tabs.create({url: urls.shift(), active: true});
-        urls.forEach(function(url) {
-          chrome.tabs.create({url: url, active: false});
-        });
+      var callback = function() {

[calamity, 2017/06/22 05:15:33]

nit: openUrls?

[tsergeant, 2017/06/22 07:47:31]

Changed it to openUrlsCallback, since I didn't really like having an openUrls()
function inside the openUrls_() function.

+        var incognito = command == Command.OPEN_INCOGNITO;
+        if (command == Command.OPEN_NEW_WINDOW || incognito) {
+          chrome.windows.create({url: urls, incognito: incognito});
+        } else {
+          if (command == Command.OPEN)
+            chrome.tabs.create({url: urls.shift(), active: true});
+          urls.forEach(function(url) {
+            chrome.tabs.create({url: url, active: false});
+          });
+        }
+      };
+
+      if (urls.length <= OPEN_CONFIRMATION_LIMIT) {
+        callback();
+        return;
       }
+
+      this.confirmOpenString_ =

[calamity, 2017/06/22 05:15:33]

Is this worth making a property? Can we just get the body of the dialog and set
it to this?

[tsergeant, 2017/06/22 07:47:31]

Done.

+          loadTimeData.getStringF('openDialogBody', urls.length);
+      this.confirmOpenCallback_ = callback;
+
+      this.$.openDialog.get().showModal();
     },
 
     /**
      * Returns all URLs in the given set of nodes and their immediate children.
      * Note that these will be ordered by insertion order into the |itemIds|
      * set, and that it is possible to duplicate a URL by passing in both the
      * parent ID and child ID.
      * @param {!Set<string>} itemIds
      * @return {!Array<string>}
      * @private
@@ skipping 82 matching lines @@
      * @param {Event} e
      * @private
      */
     onMenuMousedown_: function(e) {
       if (e.path[0] != this.$.dropdown)
         return;
 
       this.closeCommandMenu();
     },
 
+    /** @private */
+    onOpenCancelTap_: function() {
+      this.$.openDialog.get().cancel();
+    },
+
+    /** @private */
+    onOpenConfirmTap_: function() {
+      this.confirmOpenCallback_();
+      this.$.openDialog.get().close();
+    },
+
     /**
      * @param {Command} command
      * @return {string}
      * @private
      */
     getCommandLabel_: function(command) {
       var multipleNodes = this.menuIds_.size > 1 ||
           this.containsMatchingNode_(this.menuIds_, function(node) {
             return !node.url;
           });
@@ skipping 43 matching lines @@
 
   /** @return {!bookmarks.CommandManager} */
   CommandManager.getInstance = function() {
     return assert(CommandManager.instance_);
   };
 
   return {
     CommandManager: CommandManager,
   };
 });