Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: content/shell/app/shell_main_delegate.cc

Issue 2945453002: color: Use base::Feature to control color correct rendering (Closed)
Patch Set: Add histogram enum Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/gpu/render_widget_compositor.cc ('k') | content/test/layouttest_support.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/app/shell_main_delegate.cc
diff --git a/content/shell/app/shell_main_delegate.cc b/content/shell/app/shell_main_delegate.cc
index f496af7313ade6096dea3592b6f5ee883fdc686d..6cfffb6b94764ace8507b09652c85be652ee5de2 100644
--- a/content/shell/app/shell_main_delegate.cc
+++ b/content/shell/app/shell_main_delegate.cc
@@ -213,9 +213,7 @@ bool ShellMainDelegate::BasicStartupComplete(int* exit_code) {
command_line.AppendSwitch(switches::kDisableGpuRasterization);
}
- // Enable color correct rendering. If the virtual test suite didn't specify
- // a color space, then use sRGB.
- command_line.AppendSwitch(switches::kEnableColorCorrectRendering);
+ // If the virtual test suite didn't specify a color space, then force sRGB.
if (!command_line.HasSwitch(switches::kForceColorProfile))
command_line.AppendSwitchASCII(switches::kForceColorProfile, "srgb");
@@ -234,6 +232,13 @@ bool ShellMainDelegate::BasicStartupComplete(int* exit_code) {
*exit_code = 1;
return true;
}
+
+ // Enable additional base::Features. Note that there already may exist a
+ // list of enabled features from the virtual or physical test suite.
+ std::string enabled_features =
+ command_line.GetSwitchValueASCII(switches::kEnableFeatures);
+ enabled_features = "ColorCorrectRendering," + enabled_features;
+ command_line.AppendSwitchASCII(switches::kEnableFeatures, enabled_features);
}
content_client_.reset(base::CommandLine::ForCurrentProcess()->HasSwitch(
« no previous file with comments | « content/renderer/gpu/render_widget_compositor.cc ('k') | content/test/layouttest_support.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698