Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html

Issue 2945433002: MD Settings: fix incorrect behavior with Enter on bluetooth item's icon-button. (Closed)
Patch Set: be explicit about event param Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 2
3 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 3 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
4 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 4 <link rel="import" href="chrome://resources/cr_elements/icons.html">
5 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> 5 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">
8 <link rel="import" href="../settings_shared_css.html"> 8 <link rel="import" href="../settings_shared_css.html">
9 9
10 <dom-module id="bluetooth-device-list-item"> 10 <dom-module id="bluetooth-device-list-item">
(...skipping 16 matching lines...) Expand all
27 </div> 27 </div>
28 <div class="state secondary" connected$="[[device.connected]]" 28 <div class="state secondary" connected$="[[device.connected]]"
29 hidden$="[[!hasConnectionStatusText_(device)]]"> 29 hidden$="[[!hasConnectionStatusText_(device)]]">
30 [[getConnectionStatusText_(device)]] 30 [[getConnectionStatusText_(device)]]
31 </div> 31 </div>
32 </div> 32 </div>
33 <span hidden$="[[!device.connecting]]">$i18n{bluetoothConnecting}</span> 33 <span hidden$="[[!device.connecting]]">$i18n{bluetoothConnecting}</span>
34 <div hidden$="[[!device.paired]]"> 34 <div hidden$="[[!device.paired]]">
35 <button is="paper-icon-button-light" class="icon-more-vert" 35 <button is="paper-icon-button-light" class="icon-more-vert"
36 on-tap="onMenuButtonTap_" tabindex$="[[tabindex]]" 36 on-tap="onMenuButtonTap_" tabindex$="[[tabindex]]"
37 title="$i18n{moreActions}"> 37 title="$i18n{moreActions}" on-keydown="ignoreEnterKey_">
38 </button> 38 </button>
39 <dialog id="dotsMenu" is="cr-action-menu"> 39 <dialog id="dotsMenu" is="cr-action-menu">
40 <button class="dropdown-item" role="option" 40 <button class="dropdown-item" role="option"
41 on-tap="onConnectActionTap_"> 41 on-tap="onConnectActionTap_">
42 [[getConnectActionText_(device.connected)]] 42 [[getConnectActionText_(device.connected)]]
43 </button> 43 </button>
44 <button class="dropdown-item" role="option" on-tap="onRemoveTap_"> 44 <button class="dropdown-item" role="option" on-tap="onRemoveTap_">
45 $i18n{bluetoothRemove} 45 $i18n{bluetoothRemove}
46 </button> 46 </button>
47 </dialog> 47 </dialog>
48 </div> 48 </div>
49 </div> 49 </div>
50 </template> 50 </template>
51 <script src="bluetooth_device_list_item.js"></script> 51 <script src="bluetooth_device_list_item.js"></script>
52 </dom-module> 52 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698