Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 2945313002: Remove the unused class SingleContextManager (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
devoncarew
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1114 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +8 lines, -15 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +1 line, -10 lines 0 comments Download
D pkg/analysis_server/lib/src/single_context_manager.dart View 1 chunk +0 lines, -533 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 3 chunks +1 line, -4 lines 0 comments Download
D pkg/analysis_server/test/single_context_manager_test.dart View 1 chunk +0 lines, -548 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 6 months ago (2017-06-21 16:20:30 UTC) #2
devoncarew
lgtm
3 years, 6 months ago (2017-06-21 17:47:05 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-21 18:21:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fcb23e967cd286fb7091752f178fe77c1c4ac982 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698