Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Unified Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

Issue 2945223002: Add deprecation warnings for permission API usage from iframes (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
diff --git a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
index a8d3a56702570f413215fe4321c9cdc72242422b..f483a7e27f52c5533aca0fbde2ad9f1765ec6f81 100644
--- a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
+++ b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
@@ -41,6 +41,7 @@
#include "platform/wtf/Assertions.h"
#include "platform/wtf/CurrentTime.h"
#include "public/platform/Platform.h"
+#include "public/platform/WebFeaturePolicyFeature.h"
#include "services/service_manager/public/cpp/interface_provider.h"
namespace blink {
@@ -151,6 +152,8 @@ void Geolocation::RecordOriginTypeAccess() const {
UseCounter::Count(document, WebFeature::kGeolocationSecureOrigin);
UseCounter::CountCrossOriginIframe(
*document, WebFeature::kGeolocationSecureOriginIframe);
+ Deprecation::CountDeprecationFeaturePolicy(
+ *document, WebFeaturePolicyFeature::kGeolocation);
} else if (GetFrame()
->GetSettings()
->GetAllowGeolocationOnInsecureOrigins()) {
@@ -165,6 +168,8 @@ void Geolocation::RecordOriginTypeAccess() const {
WebFeature::kGeolocationInsecureOriginIframeDeprecatedNotRemoved);
HostsUsingFeatures::CountAnyWorld(
*document, HostsUsingFeatures::Feature::kGeolocationInsecureHost);
+ Deprecation::CountDeprecationFeaturePolicy(
+ *document, WebFeaturePolicyFeature::kGeolocation);
} else {
Deprecation::CountDeprecation(document,
WebFeature::kGeolocationInsecureOrigin);

Powered by Google App Engine
This is Rietveld 408576698