Add deprecation warnings for permission API usage from iframes

third_party/WebKit/Source/core/frame/Deprecation.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/Deprecation.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/frame/FrameConsole.h"
 #include "core/frame/LocalFrame.h"
 #include "core/inspector/ConsoleMessage.h"
 #include "core/page/Page.h"
 #include "core/workers/WorkerOrWorkletGlobalScope.h"
+#include "public/platform/WebFeaturePolicyFeature.h"

[ddorwin, 2017/07/05 20:29:20]

In this file, the URL is out of date. It should be
https://github.com/WICG/feature-policy/blob/gh-pages/features.md.

[raymes, 2017/07/06 03:48:03]

Done.

 
 namespace {
 
 enum Milestone {
   M60,
   M61,
   M62,
   M63,
   M64,
   M65,
@@ skipping 39 matching lines @@
 String replacedWillBeRemoved(const char* feature,
                              const char* replacement,
                              Milestone milestone,
                              const char* details) {
   return String::Format(
       "%s is deprecated and will be removed in %s. Please use %s instead. See "
       "https://www.chromestatus.com/features/%s for more details.",
       feature, milestoneString(milestone), replacement, details);
 }
 
+String iframePermissionsWarning(const char* function,

[dcheng, 2017/07/05 20:18:02]

2 nits:
- please use UpperCamelCase for function names to match the new Blink style:
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/blink-...
- I would suggest naming this DeprecatedWillBeDisabledInCrossOriginSubframe.
It's a bit wordy, but describes the purpose exactly.

[raymes, 2017/07/06 03:48:03]

Done.

+                                const char* allow_string,
+                                Milestone milestone) {
+  return String::Format(
+      "%s usage in cross-origin iframes is deprecated and will be disabled in "
+      "%s. To continue to use this feature, it must be enabled by the "
+      "embedding document using Feature Policy, e.g. "
+      "<iframe allow=\"%s\" ...>. See https://goo.gl/EuHzyv for more details.",
+      function, milestoneString(milestone), allow_string);
+}
+
 }  // anonymous namespace
 
 namespace blink {
 
 Deprecation::Deprecation() : mute_count_(0) {
   css_property_deprecation_bits_.EnsureSize(numCSSPropertyIDs);
 }
 
 Deprecation::~Deprecation() {}
 
@@ skipping 90 matching lines @@
 }
 
 void Deprecation::CountDeprecationCrossOriginIframe(const Document& document,
                                                     WebFeature feature) {
   LocalFrame* frame = document.GetFrame();
   if (!frame)
     return;
   CountDeprecationCrossOriginIframe(frame, feature);
 }
 
+void Deprecation::CountDeprecationFeaturePolicy(
+    const Document& document,
+    WebFeaturePolicyFeature feature) {
+  LocalFrame* frame = document.GetFrame();
+  if (!frame)
+    return;
+
+  // If the feature is allowed, don't log a warning.
+  if (frame->IsFeatureEnabled(feature))
+    return;
+
+  // If the feature is disabled, log a warning but only if the request is from a
+  // cross-origin iframe. Ideally we would check here if the feature is actually
+  // disabled due to the parent frame's policy (as opposed to the current frame
+  // disabling the feature on itself) but that can't happen right now anyway
+  // (until the general syntax is shipped) and this is also a good enough
+  // approximation for deprecation messages.
+  switch (feature) {
+    case WebFeaturePolicyFeature::kEme:

[ddorwin, 2017/07/05 20:29:20]

nit: I suggest making this kEncryptedMedia as that term is more common in Blink
and clearer to those not familiar with the spec.

[raymes, 2017/07/06 03:48:03]

That would be ok, but I'd prefer not to do it in the CL if we can.

+      CountDeprecationCrossOriginIframe(
+          frame, WebFeature::kEncryptedMediaDisabledCrossOriginIframe);
+      break;
+    case WebFeaturePolicyFeature::kGeolocation:
+      CountDeprecationCrossOriginIframe(
+          frame, WebFeature::kGeolocationDisabledCrossOriginIframe);
+      break;
+    case WebFeaturePolicyFeature::kMicrophone:
+      CountDeprecationCrossOriginIframe(
+          frame, WebFeature::kGetUserMediaMicDisabledCrossOriginIframe);
+      break;
+    case WebFeaturePolicyFeature::kCamera:
+      CountDeprecationCrossOriginIframe(
+          frame, WebFeature::kGetUserMediaCameraDisabledCrossOriginIframe);
+      break;
+    case WebFeaturePolicyFeature::kMidiFeature:
+      CountDeprecationCrossOriginIframe(
+          frame, WebFeature::kRequestMIDIAccessDisabledCrossOriginIframe);
+      break;
+    default:
+      NOTREACHED();
+  }
+}
+
 String Deprecation::DeprecationMessage(WebFeature feature) {
   switch (feature) {
     // Quota
     case WebFeature::kPrefixedStorageInfo:
       return replacedBy("'window.webkitStorageInfo'",
                         "'navigator.webkitTemporaryStorage' or "
                         "'navigator.webkitPersistentStorage'");
 
     case WebFeature::kConsoleMarkTimeline:
       return replacedBy("'console.markTimeline'", "'console.timeStamp'");
@@ skipping 249 matching lines @@
     case WebFeature::kDeprecatedTimingFunctionStepMiddle:
       return replacedWillBeRemoved(
           "The step timing function with step position 'middle'",
           "the frames timing function", M62, "5189363944128512");
     case WebFeature::kHTMLImportsHasStyleSheets:
       return String::Format(
           "Styling master document from stylesheets defined in HTML Imports "
           "is deprecated, and is planned to be removed in %s. Please refer to "
           "https://goo.gl/EGXzpw for possible migration paths.",
           milestoneString(M65));
+    case WebFeature::kEncryptedMediaDisabledCrossOriginIframe:
+      return iframePermissionsWarning("requestMediaKeySystemAccess",
+                                      "encrypted-media", M63);
+    case WebFeature::kGeolocationDisabledCrossOriginIframe:
+      return iframePermissionsWarning("getCurrentPosition and watchPosition",
+                                      "geolocation", M63);
+    case WebFeature::kGetUserMediaMicDisabledCrossOriginIframe:
+      return iframePermissionsWarning("getUserMedia (microphone)", "microphone",
+                                      M63);
+    case WebFeature::kGetUserMediaCameraDisabledCrossOriginIframe:
+      return iframePermissionsWarning("getUserMedia (camera)", "camera", M63);
+    case WebFeature::kRequestMIDIAccessDisabledCrossOriginIframe:
+      return iframePermissionsWarning("requestMIDIAccess", "midi", M63);
 
     // Features that aren't deprecated don't have a deprecation message.
     default:
       return String();
   }
 }
 
 }  // namespace blink