Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2945173007: Omnibox UI Experiments: Enable trimming of trivial subdomains. (Closed)

Created:
3 years, 6 months ago by tommycli
Modified:
3 years, 5 months ago
Reviewers:
Justin Donnelly
CC:
chromium-reviews, jdonnelly+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox UI Experiments: Enable trimming of trivial subdomains. This trims trivial subdomains whenever the experimental flag is on. We still need to followup and add a match_in_subdomain flag to prevent trimming of trivial subdomains that are part of the match. Depends on https://codereview.chromium.org/2939423003/ landing first. BUG=732582

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M components/omnibox/browser/autocomplete_match.cc View 1 chunk +12 lines, -1 line 3 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
tommycli
jdonnelly: PTAL, thanks! https://codereview.chromium.org/2945173007/diff/1/components/omnibox/browser/autocomplete_match.cc File components/omnibox/browser/autocomplete_match.cc (right): https://codereview.chromium.org/2945173007/diff/1/components/omnibox/browser/autocomplete_match.cc#newcode538 components/omnibox/browser/autocomplete_match.cc:538: } This pattern now makes me ...
3 years, 6 months ago (2017-06-23 00:10:54 UTC) #2
Justin Donnelly
Maybe mention in the description that this depends on https://codereview.chromium.org/2939423003/ since that hasn't landed yet. ...
3 years, 6 months ago (2017-06-23 15:12:25 UTC) #7
tommycli
On 2017/06/23 15:12:25, Justin Donnelly wrote: > Maybe mention in the description that this depends ...
3 years, 6 months ago (2017-06-23 18:22:41 UTC) #9
tommycli
https://codereview.chromium.org/2945173007/diff/1/components/omnibox/browser/autocomplete_match.cc File components/omnibox/browser/autocomplete_match.cc (right): https://codereview.chromium.org/2945173007/diff/1/components/omnibox/browser/autocomplete_match.cc#newcode538 components/omnibox/browser/autocomplete_match.cc:538: } On 2017/06/23 15:12:25, Justin Donnelly wrote: > On ...
3 years, 6 months ago (2017-06-23 18:23:06 UTC) #10
Justin Donnelly
3 years, 6 months ago (2017-06-23 19:55:33 UTC) #11
lgtm

Oops! Sorry, I meant to have lgtm'd this in my previous message.

Powered by Google App Engine
This is Rietveld 408576698