VR: Enforce LTR directionality on rendered URL text.

chrome/browser/android/vr_shell/textures/url_bar_texture.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/textures/url_bar_texture.h"
 
-#include "base/i18n/rtl.h"
 #include "base/strings/utf_string_conversions.h"
 #include "cc/paint/skia_paint_canvas.h"
 #include "chrome/browser/android/vr_shell/color_scheme.h"
 #include "chrome/browser/android/vr_shell/textures/render_text_wrapper.h"
 #include "components/strings/grit/components_strings.h"
 #include "components/toolbar/vector_icons.h"
 #include "components/url_formatter/url_formatter.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/font.h"
@@ skipping 328 matching lines @@
   }
 }
 
 void UrlBarTexture::RenderUrl(const gfx::Size& texture_size,
                               const gfx::Rect& bounds) {
   url::Parsed parsed;
   const base::string16 text = url_formatter::FormatUrl(
       gurl_, url_formatter::kFormatUrlOmitAll, net::UnescapeRule::NORMAL,
       &parsed, nullptr, nullptr);
 
-  if (base::i18n::StringContainsStrongRTLChars(text))
-    failure_callback_.Run(UiUnsupportedMode::kURLWithStrongRTLChars);
-
   int pixel_font_height = texture_size.height() * kFontHeight / kHeight;
 
   gfx::FontList font_list;
   if (!GetFontList(pixel_font_height, text, &font_list))
     failure_callback_.Run(UiUnsupportedMode::kUnhandledCodePoint);
 
   std::unique_ptr<gfx::RenderText> render_text(
       gfx::RenderText::CreateInstance());
   render_text->SetFontList(font_list);
   render_text->SetColor(SK_ColorBLACK);
   render_text->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   render_text->SetElideBehavior(gfx::ELIDE_TAIL);
+  render_text->SetDirectionalityMode(gfx::DIRECTIONALITY_FORCE_LTR);
   render_text->SetText(text);
   render_text->SetDisplayRect(bounds);
 
   // Until we can properly elide a URL, we need to bail if the origin portion
   // cannot be displayed in its entirety.
   base::string16 mandatory_prefix = text;
   int length = parsed.CountCharactersBefore(url::Parsed::PORT, false);
   if (length > 0)
     mandatory_prefix = text.substr(0, length);
   // Ellipsis-based eliding replaces the last character in the string with an
   // ellipsis, so to reliably check that the origin is intact, check both length
   // and string equality.
   if (render_text->GetDisplayText().size() < mandatory_prefix.size() ||
       render_text->GetDisplayText().substr(0, mandatory_prefix.size()) !=
           mandatory_prefix) {
     failure_callback_.Run(UiUnsupportedMode::kCouldNotElideURL);
   }
 
   vr_shell::RenderTextWrapper vr_render_text(render_text.get());
   ApplyUrlStyling(text, parsed, security_level_, &vr_render_text,
                   color_scheme());
 
   url_render_text_ = std::move(render_text);
+  url_text_ = text;
 }
 
 // This method replicates behavior in OmniboxView::UpdateTextStyle(), and
 // attempts to maintain similar code structure.
 void UrlBarTexture::ApplyUrlStyling(
     const base::string16& formatted_url,
     const url::Parsed& parsed,
     const security_state::SecurityLevel security_level,
     vr_shell::RenderTextWrapper* render_text,
     const ColorScheme& color_scheme) {
@@ skipping 57 matching lines @@
 
 gfx::Size UrlBarTexture::GetPreferredTextureSize(int maximum_width) const {
   return gfx::Size(maximum_width, maximum_width * kHeight / kWidth);
 }
 
 gfx::SizeF UrlBarTexture::GetDrawnSize() const {
   return size_;
 }
 
 }  // namespace vr_shell