content/browser/frame_host/interstitial_page_impl.cc - Issue 2945163002: Avoid use-after-free when InterstitialPageImpl is being torn down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 2945163002: Avoid use-after-free when InterstitialPageImpl is being torn down. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/interstitial_page_impl.cc

diff --git a/content/browser/frame_host/interstitial_page_impl.cc b/content/browser/frame_host/interstitial_page_impl.cc

index d890e64f44973d7163083f85db7c569be1b2f0f6..90e4de3815895910f0db1c9d41d0b4cf0672f708 100644

--- a/content/browser/frame_host/interstitial_page_impl.cc

+++ b/content/browser/frame_host/interstitial_page_impl.cc

@@ -811,6 +811,10 @@ FrameTree* InterstitialPageImpl::GetFrameTree() {

void InterstitialPageImpl::Disable() {

enabled_ = false;

+ // Also let the InterstitialPageNavigatorImpl know.

+ static_cast<InterstitialPageNavigatorImpl*>(frame_tree_->root()->navigator())

+ ->Disable();

}

void InterstitialPageImpl::Shutdown() {

« no previous file with comments | « no previous file | content/browser/frame_host/interstitial_page_navigator_impl.h » ('j') | no next file with comments »