chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h - Issue 2945143002: Modify the accessibility highlight manager to account for the text caret being drawn outside of the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h

Issue 2945143002: Modify the accessibility highlight manager to account for the text caret being drawn outside of the… (Closed)

Patch Set: Modify the accessibility highlight manager to account for the text caret being drawn outside of the… Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc » ('j') | chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h

diff --git a/chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h b/chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h

index facbcbb76448c2bfb2a03033a052d5150aedcb47..36b9eff5f5fd3d5605d5d6470c0629e3748e882f 100644

--- a/chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h

+++ b/chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h

@@ -46,6 +46,8 @@ class AccessibilityHighlightManager

protected:

FRIEND_TEST_ALL_PREFIXES(AccessibilityFocusRingControllerTest,

CursorWorksOnMultipleDisplays);

+ FRIEND_TEST_ALL_PREFIXES(AccessibilityFocusRingControllerTest,

+ CaretRingDrawnOnlyWithinBounds);

// ui::EventHandler overrides:

void OnMouseEvent(ui::MouseEvent* event) override;

@@ -71,6 +73,7 @@ class AccessibilityHighlightManager

virtual bool IsCursorVisible();

private:

+ bool IsCaretVisible(const gfx::Rect caret_bounds);

dmazzoni 2017/06/22 04:54:49 nit: const gfx::Rect&

Maajid 2017/06/27 02:25:16 Done.

void UpdateFocusAndCaretHighlights();

void UpdateCursorHighlight();