Issue 2945003: AutoFill DCHECK in RenderViewHost::AutocompleteSuggestionsReturned fails.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2945003: AutoFill DCHECK in RenderViewHost::AutocompleteSuggestionsReturned fails. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by dhollowa

Modified:
4 years ago

Reviewers:
James Hawkins

CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

AutoFill DCHECK in RenderViewHost::AutocompleteSuggestionsReturned fails. Fixes case where DCHECK was failing in presence of Autocomplete cancel logic. The DCHECK in this case was erroneous. The new logic handles the cancel case appropriately. BUG=none TEST=AutoFillManagerTest.GetFieldSuggestionsForAutocompleteOnly Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51962

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -1 line)			Patch
	M	chrome/browser/autofill/autofill_manager_unittest.cc	View		1 chunk	+36 lines, -0 lines	0 comments	Download
	M	chrome/browser/renderer_host/render_view_host.cc	View		1 chunk	+9 lines, -1 line	0 comments	Download

Trybot results: win linux mac

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages