Chromium Code Reviews
Help | Chromium Project | Sign in
(491)

Issue 2945003: AutoFill DCHECK in RenderViewHost::AutocompleteSuggestionsReturned fails. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by dhollowa
Modified:
4 years ago
Reviewers:
James Hawkins
CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

AutoFill DCHECK in RenderViewHost::AutocompleteSuggestionsReturned fails. Fixes case where DCHECK was failing in presence of Autocomplete cancel logic. The DCHECK in this case was erroneous. The new logic handles the cancel case appropriately. BUG=none TEST=AutoFillManagerTest.GetFieldSuggestionsForAutocompleteOnly Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51962

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M chrome/browser/autofill/autofill_manager_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +9 lines, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
dhollowa
4 years, 10 months ago (2010-07-08 19:27:34 UTC) #1
James Hawkins
4 years, 10 months ago (2010-07-08 22:06:46 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be