chrome/browser/extensions/api/storage/backend_task_runner.h - Issue 2944993002: Remove dependency on BrowserThread::FILE from Sync code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/storage/backend_task_runner.h

Issue 2944993002: Remove dependency on BrowserThread::FILE from Sync code (Closed)

Patch Set: Changed iOS specific version of CreateModelWorkerForGroup Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/BUILD.gn ('k') | chrome/browser/extensions/api/storage/backend_task_runner.cc » ('j') | chrome/browser/extensions/api/storage/backend_task_runner.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
	Devlin 2017/06/21 00:25:21 no (c) in new files no (c) in new files stanisc 2017/06/21 17:20:54 Done. Show quoted text On 2017/06/21 00:25:21, Devlin wrote: > no (c) in new files Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_EXTENSIONS_API_STORAGE_BACKEND_TASK_RUNNER_H_

	6 #define CHROME_BROWSER_EXTENSIONS_API_STORAGE_BACKEND_TASK_RUNNER_H_

	7

	8 #include "base/memory/ref_counted.h"

	9 #include "base/sequenced_task_runner.h"

	10

	11 namespace extensions {

	12

	13 // Gets the singleton task runner for running Extensions storage backend tasks.
	Devlin 2017/06/21 00:25:20 Maybe explain what a "storage backend" task includ Maybe explain what a "storage backend" task includes? stanisc 2017/06/21 17:20:55 I don't actually know exactly what needs to be pos Show quoted text On 2017/06/21 00:25:20, Devlin wrote: > Maybe explain what a "storage backend" task includes? I don't actually know exactly what needs to be posted on this task runner. I think at a minimum anything related to SyncStorageBackend needs to be on this runner to ensure that the same sequence is shared with the sync. It looks like both StorageFrontend and SyncValueStoreCache need to be switched but likely more extensions code that is currently posting on the FILE thread might need to be switched to this task runner as well. I'd appreciate your help in figuring that out. I'll follow up on that in a separate patch. Devlin 2017/06/21 19:19:30 Yeah, I'm sure there will be more code to be updat Show quoted text On 2017/06/21 17:20:55, stanisc wrote: > On 2017/06/21 00:25:20, Devlin wrote: > > Maybe explain what a "storage backend" task includes? > > I don't actually know exactly what needs to be posted on this task runner. > I think at a minimum anything related to SyncStorageBackend needs to be on this > runner to ensure that the same sequence is shared with the sync. > It looks like both StorageFrontend and SyncValueStoreCache need to be switched > but likely more extensions code that is currently posting on the FILE thread > might need to be switched to this task runner as well. I'd appreciate your help > in figuring that out. I'll follow up on that in a separate patch. > Yeah, I'm sure there will be more code to be updated, but having this CL targeted is good. I like your new phrasing since it's clear what this is used for currently.
	14 scoped_refptr<base::SequencedTaskRunner> GetBackendTaskRunner();

	15

	16 } // namespace extensions

	17

	18 #endif // CHROME_BROWSER_EXTENSIONS_API_STORAGE_BACKEND_TASK_RUNNER_H_

OLD	NEW