Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: milo/appengine/buildbucket/html.go

Issue 2944983003: [milo] {buildbucket,buildbot,swarming,logdog} -> backends/*. (Closed)
Patch Set: fix the tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/buildbucket/html.go
diff --git a/milo/appengine/buildbucket/html.go b/milo/appengine/buildbucket/html.go
deleted file mode 100644
index 8cb382f88e37a22899d3c64d07acb1e51cd08d56..0000000000000000000000000000000000000000
--- a/milo/appengine/buildbucket/html.go
+++ /dev/null
@@ -1,59 +0,0 @@
-// Copyright 2016 The LUCI Authors. All rights reserved.
-// Use of this source code is governed under the Apache License, Version 2.0
-// that can be found in the LICENSE file.
-
-package buildbucket
-
-import (
- "errors"
- "net/http"
-
- "golang.org/x/net/context"
-
- "github.com/julienschmidt/httprouter"
- "github.com/luci/luci-go/milo/appengine/common"
- "github.com/luci/luci-go/server/router"
- "github.com/luci/luci-go/server/templates"
-)
-
-func parseBuilderQuery(c context.Context, r *http.Request, p httprouter.Params) (
- query builderQuery, err error) {
-
- query.Bucket = p.ByName("bucket")
- if query.Bucket == "" {
- err = errors.New("No bucket")
- return
- }
-
- query.Builder = p.ByName("builder")
- if query.Builder == "" {
- err = errors.New("No builder")
- return
- }
-
- // limit is a name of the query string parameter for specifying
- // maximum number of builds to show.
- query.Limit, err = common.GetLimit(r)
- return
-}
-
-// BuilderHandler renders the builder view page.
-// Note: The builder html template contains self links to "?limit=123", which could
-// potentially override any other request parameters set.
-func BuilderHandler(c *router.Context) {
- query, err := parseBuilderQuery(c.Context, c.Request, c.Params)
- if err != nil {
- common.ErrorPage(c, http.StatusBadRequest, err.Error())
- return
- }
-
- result, err := builderImpl(c.Context, query)
- if err != nil {
- common.ErrorPage(c, http.StatusInternalServerError, err.Error())
- return
- }
-
- templates.MustRender(c.Context, c.Writer, "pages/builder.html", templates.Args{
- "Builder": result,
- })
-}

Powered by Google App Engine
This is Rietveld 408576698