Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: milo/appengine/buildbot/grpc_test.go

Issue 2944983003: [milo] {buildbucket,buildbot,swarming,logdog} -> backends/*. (Closed)
Patch Set: fix the tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/buildbot/grpc.go ('k') | milo/appengine/buildbot/html.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbot/grpc_test.go
diff --git a/milo/appengine/buildbot/grpc_test.go b/milo/appengine/buildbot/grpc_test.go
deleted file mode 100644
index 7035068ef1eab39e9e71acc15f66bc000d85b3e3..0000000000000000000000000000000000000000
--- a/milo/appengine/buildbot/grpc_test.go
+++ /dev/null
@@ -1,143 +0,0 @@
-// Copyright 2016 The LUCI Authors. All rights reserved.
-// Use of this source code is governed under the Apache License, Version 2.0
-// that can be found in the LICENSE file.
-
-package buildbot
-
-import (
- "testing"
-
- "google.golang.org/grpc"
- "google.golang.org/grpc/codes"
-
- "github.com/luci/gae/impl/memory"
- ds "github.com/luci/gae/service/datastore"
- "github.com/luci/luci-go/common/clock/testclock"
- milo "github.com/luci/luci-go/milo/api/proto"
- . "github.com/smartystreets/goconvey/convey"
- "golang.org/x/net/context"
-)
-
-func TestGRPC(t *testing.T) {
- c := memory.Use(context.Background())
- c, _ = testclock.UseTime(c, testclock.TestTimeUTC)
-
- Convey(`A test environment`, t, func() {
- name := "testmaster"
- bname := "testbuilder"
- master := &buildbotMaster{
- Name: name,
- Builders: map[string]*buildbotBuilder{"fake": {}},
- Slaves: map[string]*buildbotSlave{
- "foo": {
- RunningbuildsMap: map[string][]int{
- "fake": {1},
- },
- },
- },
- }
-
- So(putDSMasterJSON(c, master, false), ShouldBeNil)
- So(ds.Put(c, &buildbotBuild{
- Master: name,
- Buildername: "fake",
- Number: 1,
- }), ShouldBeNil)
- ds.GetTestable(c).Consistent(true)
- ds.GetTestable(c).AutoIndex(true)
- svc := Service{}
-
- Convey(`Get finished builds`, func() {
- // Add in some builds.
- for i := 0; i < 5; i++ {
- ds.Put(c, &buildbotBuild{
- Master: name,
- Buildername: bname,
- Number: i,
- Finished: true,
- })
- }
- ds.Put(c, &buildbotBuild{
- Master: name,
- Buildername: bname,
- Number: 6,
- Finished: false,
- })
- ds.GetTestable(c).CatchupIndexes()
-
- r := &milo.BuildbotBuildsRequest{
- Master: name,
- Builder: bname,
- }
- result, err := svc.GetBuildbotBuildsJSON(c, r)
- So(err, ShouldBeNil)
- So(len(result.Builds), ShouldEqual, 5)
-
- Convey(`Also get incomplete builds`, func() {
- r := &milo.BuildbotBuildsRequest{
- Master: name,
- Builder: bname,
- IncludeCurrent: true,
- }
- result, err := svc.GetBuildbotBuildsJSON(c, r)
- So(err, ShouldBeNil)
- So(len(result.Builds), ShouldEqual, 6)
- })
-
- Convey(`Good cursor`, func() {
- r.Cursor = result.GetCursor()
- _, err := svc.GetBuildbotBuildsJSON(c, r)
- So(err, ShouldBeNil)
- })
- Convey(`Bad cursor`, func() {
- r.Cursor = "foobar"
- _, err := svc.GetBuildbotBuildsJSON(c, r)
- So(err, ShouldResemble,
- grpc.Errorf(codes.InvalidArgument,
- "Invalid cursor: Failed to Base64-decode cursor: illegal base64 data at input byte 4"))
- })
- Convey(`Bad request`, func() {
- _, err := svc.GetBuildbotBuildsJSON(c, &milo.BuildbotBuildsRequest{})
- So(err, ShouldResemble, grpc.Errorf(codes.InvalidArgument, "No master specified"))
- _, err = svc.GetBuildbotBuildsJSON(c, &milo.BuildbotBuildsRequest{Master: name})
- So(err, ShouldResemble, grpc.Errorf(codes.InvalidArgument, "No builder specified"))
- })
- })
-
- Convey(`Get Master`, func() {
- Convey(`Bad request`, func() {
- _, err := svc.GetCompressedMasterJSON(c, &milo.MasterRequest{})
- So(err, ShouldResemble, grpc.Errorf(codes.InvalidArgument, "No master specified"))
- })
- _, err := svc.GetCompressedMasterJSON(c, &milo.MasterRequest{Name: name})
- So(err, ShouldBeNil)
- })
-
- Convey(`Get Build`, func() {
- Convey(`Invalid input`, func() {
- _, err := svc.GetBuildbotBuildJSON(c, &milo.BuildbotBuildRequest{})
- So(err, ShouldResemble, grpc.Errorf(codes.InvalidArgument, "No master specified"))
- _, err = svc.GetBuildbotBuildJSON(c, &milo.BuildbotBuildRequest{
- Master: "foo",
- })
- So(err, ShouldResemble, grpc.Errorf(codes.InvalidArgument, "No builder specified"))
- })
- Convey(`Basic`, func() {
- _, err := svc.GetBuildbotBuildJSON(c, &milo.BuildbotBuildRequest{
- Master: name,
- Builder: "fake",
- BuildNum: 1,
- })
- So(err, ShouldBeNil)
- })
- Convey(`Basic Not found`, func() {
- _, err := svc.GetBuildbotBuildJSON(c, &milo.BuildbotBuildRequest{
- Master: name,
- Builder: "fake",
- BuildNum: 2,
- })
- So(err, ShouldResemble, grpc.Errorf(codes.Unauthenticated, "Unauthenticated request"))
- })
- })
- })
-}
« no previous file with comments | « milo/appengine/buildbot/grpc.go ('k') | milo/appengine/buildbot/html.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698