Implement type inference for null-aware property gets.

Implement type inference for null-aware property gets.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/a4743540d0ef81a9d8c0cef334c8d91bbe961ef7

[Paul Berry, 2017-06-19 21:33:32]

paulberry@google.com changed reviewers:
+ ahe@google.com, sigmund@google.com

[Paul Berry, 2017-06-19 21:33:32]

I only need a review from one of you.

[Siggi Cherem (dart-lang), 2017-06-19 21:47:43]

lgtm

https://codereview.chromium.org/2944933002/diff/1/pkg/front_end/testcases/inf...
File
pkg/front_end/testcases/inference/null_aware_property_get.dart.strong.expect
(right):

https://codereview.chromium.org/2944933002/diff/1/pkg/front_end/testcases/inf...
pkg/front_end/testcases/inference/null_aware_property_get.dart.strong.expect:12:
core::int x = let final dynamic #t1 = c in #t1.==(null) ? null :
#t1.{self::C::x};
unrelated to this CL, but I noticed the `let dynamic` here - do you plan to add
inference of the let variables too?

[Paul Berry, 2017-06-19 22:06:53]

https://codereview.chromium.org/2944933002/diff/1/pkg/front_end/testcases/inf...
File
pkg/front_end/testcases/inference/null_aware_property_get.dart.strong.expect
(right):

https://codereview.chromium.org/2944933002/diff/1/pkg/front_end/testcases/inf...
pkg/front_end/testcases/inference/null_aware_property_get.dart.strong.expect:12:
core::int x = let final dynamic #t1 = c in #t1.==(null) ? null :
#t1.{self::C::x};
On 2017/06/19 21:47:43, Siggi Cherem (dart-lang) wrote:
> unrelated to this CL, but I noticed the `let dynamic` here - do you plan to
add
> inference of the let variables too?

Good point.  I'll address this in a follow up CL.

[Paul Berry, 2017-06-19 22:09:00]

Description was changed from

==========
Implement type inference for null-aware property gets.
==========

to

==========
Implement type inference for null-aware property gets.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a4743540d0ef81a9d8c0cef334c8d91bbe961ef7
==========

[Paul Berry, 2017-06-19 22:09:01]

Committed patchset #1 (id:1) manually as
a4743540d0ef81a9d8c0cef334c8d91bbe961ef7 (presubmit successful).