Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2944903002: Implement type inference for if-null expressions (a ?? b). (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, scheglov
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement type inference for if-null expressions (a ?? b). R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/fdf77ba36f73de7b2e515476d78147080e44798b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -3 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +50 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/inference/null_coalescing_operator.dart.strong.expect View 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/null_coalescing_operator_2.dart.strong.expect View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
I only need a review from one person.
3 years, 6 months ago (2017-06-19 20:00:52 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 6 months ago (2017-06-19 20:39:57 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-19 20:46:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fdf77ba36f73de7b2e515476d78147080e44798b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698