Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 2944873002: Printing: Disable subframes when printing a selection. (Closed)
Patch Set: Nits. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/printing/selection_iframe.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/printing/renderer/print_web_view_helper.cc
diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc
index b7cce0b2882a8ced664176879c5a2104b1b0406f..fd62c978092eabb839057408ed163bab0d6ee60d 100644
--- a/components/printing/renderer/print_web_view_helper.cc
+++ b/components/printing/renderer/print_web_view_helper.cc
@@ -839,9 +839,11 @@ blink::WebLocalFrame* PrepareFrameAndViewForPrint::CreateChildFrame(
blink::WebSandboxFlags sandbox_flags,
const blink::WebParsedFeaturePolicy& container_policy,
const blink::WebFrameOwnerProperties& frame_owner_properties) {
- blink::WebLocalFrame* frame =
- parent->CreateLocalChild(scope, this, nullptr, nullptr);
- return frame;
+ // This is called when printing a selection and when this selection contains
+ // an iframe. This is not supported yet. An empty rectangle will be displayed
+ // instead.
+ // Please see: https://crbug.com/732780.
+ return nullptr;
}
std::unique_ptr<blink::WebURLLoader>
« no previous file with comments | « chrome/test/data/printing/selection_iframe.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698