tests/compiler/dart2js/type_combination_test.dart - Issue 2944843002: All strong mode cleaning of dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/type_combination_test.dart

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)

Patch Set: More issues discovered during testing. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/type_combination_test.dart

diff --git a/tests/compiler/dart2js/type_combination_test.dart b/tests/compiler/dart2js/type_combination_test.dart

index 586976321212e9d59bcd4f47e07eac83bf3939cd..b5b0c401d8ae0fc6db11ed0fbc7b9b36e3b26266 100644

--- a/tests/compiler/dart2js/type_combination_test.dart

+++ b/tests/compiler/dart2js/type_combination_test.dart

@@ -54,8 +54,10 @@ class Pair {

final second;

Pair(this.first, this.second);

int get hashCode => first.hashCode * 47 + second.hashCode;

- bool operator ==(Pair other) =>

- identical(first, other.first) && identical(second, other.second);

+ bool operator ==(other) =>

+ other is Pair &&

+ identical(first, other.first) &&

+ identical(second, other.second);

}

class RuleSet {