pkg/compiler/lib/src/js/rewrite_async.dart - Issue 2944843002: All strong mode cleaning of dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js/rewrite_async.dart

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)

Patch Set: More issues discovered during testing. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js/rewrite_async.dart

diff --git a/pkg/compiler/lib/src/js/rewrite_async.dart b/pkg/compiler/lib/src/js/rewrite_async.dart

index 06437d7b5bf1b3bd76787daa1b3ae261e5592458..179a37f4b1d14f444cd169843879d83399b6475e 100644

--- a/pkg/compiler/lib/src/js/rewrite_async.dart

+++ b/pkg/compiler/lib/src/js/rewrite_async.dart

@@ -2036,7 +2036,7 @@ class AsyncStarRewriter extends AsyncRewriterBase {

List<int> enclosingFinallyLabels = <int>[exitLabel];

enclosingFinallyLabels.addAll(jumpTargets

.where((js.Node node) => finallyLabels[node] != null)

- .map((js.Block node) => finallyLabels[node]));

+ .map((js.Node node) => finallyLabels[node]));

addStatement(js.js.statement("# = #;", [

nextWhenCanceled,

new js.ArrayInitializer(enclosingFinallyLabels.map(js.number).toList())