Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Side by Side Diff: tests/compiler/dart2js/analyze_helper.dart

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)
Patch Set: More issues discovered during testing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyze_helper; 5 library analyze_helper;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:io'; 8 import 'dart:io';
9 import 'package:compiler/compiler.dart' as api; 9 import 'package:compiler/compiler.dart' as api;
10 import 'package:compiler/src/apiimpl.dart'; 10 import 'package:compiler/src/apiimpl.dart';
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 whiteListMap[file][messagePart]++; 125 whiteListMap[file][messagePart]++;
126 return true; 126 return true;
127 } 127 }
128 } 128 }
129 } 129 }
130 } 130 }
131 return false; 131 return false;
132 } 132 }
133 133
134 @override 134 @override
135 void report(Message message, Uri uri, int begin, int end, String text, 135 void report(covariant Message message, Uri uri, int begin, int end,
136 api.Diagnostic kind) { 136 String text, api.Diagnostic kind) {
137 if (kind == api.Diagnostic.WARNING) { 137 if (kind == api.Diagnostic.WARNING) {
138 if (checkWhiteList(uri, message, text)) { 138 if (checkWhiteList(uri, message, text)) {
139 // Suppress whitelisted warnings. 139 // Suppress whitelisted warnings.
140 lastWasWhitelisted = true; 140 lastWasWhitelisted = true;
141 if (showWhitelisted || verbose) { 141 if (showWhitelisted || verbose) {
142 super.report(message, uri, begin, end, text, kind); 142 super.report(message, uri, begin, end, text, kind);
143 } 143 }
144 return; 144 return;
145 } 145 }
146 hasWarnings = true; 146 hasWarnings = true;
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 if (checkResults != null) { 284 if (checkResults != null) {
285 result = checkResults(compiler, handler); 285 result = checkResults(compiler, handler);
286 } else { 286 } else {
287 result = handler.checkResults(); 287 result = handler.checkResults();
288 } 288 }
289 if (!result) { 289 if (!result) {
290 print(MESSAGE); 290 print(MESSAGE);
291 exit(1); 291 exit(1);
292 } 292 }
293 } 293 }
OLDNEW
« no previous file with comments | « tests/compiler/dart2js/analyze_api_test.dart ('k') | tests/compiler/dart2js/analyze_test_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698