Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 294483003: Add extensions_unittests to chromium_builder_tests target. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
CC:
chromium-reviews, James Cook
Visibility:
Public.

Description

Add extensions_unittests to chromium_builder_tests target. This is the first step into getting this target running on TS/CQ/Waterfall system. BUG=348066 TEST=green trybots R=yoz@chromium.org,stip@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271871

Patch Set 1 #

Patch Set 2 : fix compilation? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/extensions_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/test/test_extensions_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/test/test_extensions_client.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
6 years, 7 months ago (2014-05-17 04:21:41 UTC) #1
Yoyo Zhou
LGTM
6 years, 7 months ago (2014-05-19 23:20:03 UTC) #2
ghost stip (do not use)
rubber stamp lgtm
6 years, 7 months ago (2014-05-20 19:05:26 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-21 05:43:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/294483003/20001
6 years, 7 months ago (2014-05-21 05:45:12 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 07:53:54 UTC) #6
Message was sent while issue was closed.
Change committed as 271871

Powered by Google App Engine
This is Rietveld 408576698